Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for tmux-mode-indicator #237

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rbpatt2019
Copy link

Adds support for tmux-mode-indicator.
Classically, this plugin changes its background colour by mode. There is no single
bg setting in the plugin, but rather a separate one for each mode. To make the
catppuccin bg change dynamically as well, we would then need to re-implement the
logic for detecting the mode. To avoid this complexity, this PR sets all the
bg colours to the catppuccin background colour and only changes the text.

Adds support for tmux-mode-indicator. Sets colours to default to the one specified by catppuccin,
and tidies up the displayed text.
We are running a shell script, so all the set-option calls need a tmux prefix in front of them!
@rbpatt2019
Copy link
Author

Close #236.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change segments related to this PR (### Mode Indicator module)

Copy link
Contributor

@vdbe vdbe Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some options to present the modes with colors:

@vdbe
Copy link
Contributor

vdbe commented Jun 13, 2024

Feels like it would make more sense to extend the session module with color indicators for copy and sync, but then you lose the text representation.

color=$(get_tmux_option "@catppuccin_session_color" "#{?client_prefix,$thm_red,$thm_green}")

Starting to lean more to making this a builtin module instead of requiring a plugin if extending session is not enough, since re-implementing in an opinionated way would be as much or less work as configuring it in an opinionated way.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants