-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suport for tmux-mode-indicator #237
base: main
Are you sure you want to change the base?
Conversation
Adds support for tmux-mode-indicator. Sets colours to default to the one specified by catppuccin, and tidies up the displayed text.
We are running a shell script, so all the set-option calls need a tmux prefix in front of them!
Close #236. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only change segments related to this PR (### Mode Indicator module
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some options to present the modes with colors:
-
change to fg color to thm_blue/yellow/red/cyan/... (if this remains readable)
-
create the equivalent of https://github.com/MunifTanjim/tmux-mode-indicator/blob/7027903adca37c54cb8f5fa99fc113b11c23c2c4/mode_indicator.tmux#L46 but just for background color and use that as
color
(don't think you need a rewrite to make it dynamicmisread original PR) -
Same as above but set
$thm_bg
should only effect this module (don't really like this)
Feels like it would make more sense to extend the session module with color indicators for copy and sync, but then you lose the text representation. Line 6 in e7cd05f
Starting to lean more to making this a builtin module instead of requiring a plugin if extending session is not enough, since re-implementing in an opinionated way would be as much or less work as configuring it in an opinionated way. What do you think? |
Adds support for tmux-mode-indicator.
Classically, this plugin changes its background colour by mode. There is no single
bg
setting in the plugin, but rather a separate one for each mode. To make thecatppuccin
bg
change dynamically as well, we would then need to re-implement thelogic for detecting the mode. To avoid this complexity, this PR sets all the
bg
colours to the catppuccin background colour and only changes the text.