feat(whiskers): add css_* functions as filters #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
Merged
sgoudham
pushed a commit
that referenced
this pull request
Jun 3, 2024
Co-authored-by: backwardspy <backwardspy@pigeon.life>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Discord, filters for these kind of operations are better since with functions if you want to modify a color you have to set it to a variable and then invoke the function separately:
With this PR, the css_* functions have been kept but new filter versions have been added that enables this kind of behavior:
{{ red | mod(opacity=0.6) | css_rgba }}