Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: move whiskers to catppuccin/whiskers #239

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

sgoudham
Copy link
Contributor

@sgoudham sgoudham commented Jun 4, 2024

No description provided.

@sgoudham sgoudham marked this pull request as draft June 4, 2024 00:46
@nullishamy nullishamy marked this pull request as ready for review June 4, 2024 00:46
@sgoudham sgoudham changed the title chore: move whiskers to catppuccin/whiskers refactor(whiskers): move to catppuccin/whiskers Jun 4, 2024
Copy link
Contributor Author

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed all configuration relating to whiskers in the flake.nix but I think that means this will instantly start breaking if users try to upgrade without changing their input.
(Since catppuccin-toolbox.packages.${pkgs.system}.whiskers would not longer exist. )

I'm assuming we want to go about this in a way that's nicer to nix users?

cc: @nullishamy @isabelroses @getchoo - would appreciate your inputs :D

@isabelroses
Copy link
Member

You should probably add a builtins.throw "This package has move to x location"; Though this doesn't seem to easy to add seeing what has changed here.

@getchoo
Copy link
Member

getchoo commented Jun 4, 2024

-packages = forEachSystem (pkgs: lib.filterAttrs (_: v: lib.isDerivation v) (pkgs.callPackage ./nix {}));
+packages = forEachSystem (pkgs: lib.filterAttrs (_: v: lib.isDerivation v) (pkgs.callPackage ./nix { }) // { whiskers = throw "This package has been moved to x `github:catppuccin/whiskers`"; } );

and for the overlay

{
  catppuccin-whiskers = throw "This package has been moved to x `github:catppuccin/whiskers`";
}

this is the best way i could think of without refactoring the flake, as it's pretty brittle with this structure

@sgoudham sgoudham changed the title refactor(whiskers): move to catppuccin/whiskers refactor!: move whiskers to catppuccin/whiskers Jun 6, 2024
@sgoudham sgoudham merged commit c82548e into main Jun 6, 2024
6 checks passed
@sgoudham sgoudham deleted the chore/migrate-whiskers branch June 6, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants