ci: build and push Docker images on release #1
+392
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sheer brilliance! Looks really good and if it works, feel free to "ship-it" :D The only thing that might be worth looking into is to check if it's possible in the pipelines to check if the release was flagged as a "pre-release" and if so, skip the image building part (or make it optional and triggered by manual button pressing for pre-releases). We basically only want images with stable versions as they're used as base images for production services. |
Also refactor the "publish to pypi" workflow into a global "release" workflow. because the images depend on the package being published.
vayan
force-pushed
the
add-gha-docker-images
branch
from
5de41aa to
416ce64
Compare
|
Oh you're right! Added a "prereleased" workflow that will only publish to pypi and updated the previous one (pypi+images) to only trigger on "released" events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor the "publish to pypi" workflow into a global "release" workflow.
because the images depend on the package being published.
Run sample: