General Timepix3 LATRD format #305
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
- Coverage 41.70% 41.46% -0.25%
==========================================
Files 188 189 +1
Lines 16922 17094 +172
Branches 3240 3270 +30
==========================================
+ Hits 7058 7088 +30
- Misses 9214 9352 +138
- Partials 650 654 +4 |
dxtbx.model.Panel.add_mask expects ints, not longs.
This must be set before __init__().
|
Informal testing against one of @noemifrisina's test data sets shows this to be functioning as expected. Formal tests and news still to come. |
Data set data_size ought to have axes recorded in the order slow, fast.
h5py isn't quite numpy.
|
@benjaminhwilliams is this still valuable to get into main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalise the support for binned images from the Timepix3 Large Area Time Resolved Detector 'Tristan'.
WIP, needs unit tests & news at least.