Fixes for EMBL beamlines at PETRA #626
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Started to have a quick look at this now -
I will have a read through the change set and make some in-line comments |
There was a problem hiding this comment.
Small change set, but that is probably in line with what is needed. If the code for P13 and P14 is effectively the same I would keep only one of them and have it capture the serial numbers for both - unless you anticipate some future specialisation which will need different implementations.
Not yet approved as we are lacking a news fragment and I would like to check that the code makes sense by running it with real data.
|
Ah, so if I'm understanding this properly, P13 now works on the plain FormatCBFMiniEiger, so doesn't need a special format class any more. However, presumably this will break old data being analysed with the detector when it was on the previous beamtime; do you have a changeover date that we can use as a threshold for checking the serial number on the P14 Format class? |
The E-32-0017 Eiger moved to P13 on 2021-5-22, where the goniometer axis no longer needs overriding. Check for that date in the MiniCBF, and check for the serial matching the date range.
ndevenish
force-pushed
the
PETRA_EMBL_Beamlines
branch
from
b5dec97
to
c2d4819
Compare
|
So, I think that this covers the fix and move between beamlines. Thanks to Gleb Bourenkov, we know that the E-32-0107 Eiger moved to P13 on May 22nd 2021. After this date, the standard MiniCBF handling works fine, so we only need to handle P14. This should now work out what serial is expected on P14 for the timestamp, and checks for that serial. My only worry is that we don't have any example data files to test this with. |
|
@ndevenish anything stopping this from being merged? |
The E-32-0017 Eiger moved to P13 on 2021-5-22, where the goniometer axis no longer needs overriding. Check for that date in the MiniCBF, and check for the serial matching the date range. Co-authored-by: Christian Becke <christian.becke@fu-berlin.de> Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
Processing data recently collected at PETRA P13 using DIALS/XDS failed because the rotation axis was defined incorrectly. There is a new Eiger CdTe detector installed at P14 with serial number E-32-0129 and the Eiger with serial number E-32-0107 was moved to P13. This lead to the P14 rotation axis settings being applied to the P13 data, which resulted in indexing failures.