Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nxmx import overwritten by local variable #641

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Conversation

rjgildea
Copy link

Introduced by #597

Another case were bugs have crept in through lack of tests (see #470)

Unbreak help test by explicitly setting program name

rjgildea and others added 4 commits June 26, 2023 13:31
* explicitly set program name
* minor change to docstring
Introduced by #597

Another case were bugs have crept in through lack of tests (see #470)
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #641 (4917b66) into main (e7b27b4) will increase coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 4917b66 differs from pull request most recent head 40a5b7d. Consider uploading reports for the commit 40a5b7d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   39.38%   39.39%           
=======================================
  Files         178      178           
  Lines       15495    15496    +1     
  Branches     2613     2613           
=======================================
+ Hits         6103     6104    +1     
  Misses       8832     8832           
  Partials      560      560           

@ndevenish ndevenish merged commit f5e835c into main Jun 27, 2023
@ndevenish ndevenish deleted the fix-dlsnxs2cbf branch June 27, 2023 13:08
toastisme pushed a commit to toastisme/dxtbx that referenced this pull request Jul 18, 2024
* Unbreak help test
* explicitly set program name
* minor change to docstring

* Fix for nxmx import overwritten by local variable

Introduced by cctbx#597

Another case were bugs have crept in through lack of tests (see cctbx#470)

* news

* Rename newsfragments/XXX.bugfix to newsfragments/641.bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants