Flumpy: Don't allow converting 1D vectors to vec2/3 #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a size (3,) array would have erroneously converted to a 0x3 length vec3. This is now explicitly forbidden; you must pass at least a (0, 3) multidimensional array. Fixes cctbx#439.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
=======================================
Coverage 39.40% 39.40%
=======================================
Files 178 178
Lines 15542 15542
Branches 3004 3004
=======================================
Hits 6125 6125
Misses 8836 8836
Partials 581 581 |
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
Previously, a size (3,) array would have erroneously converted to a 0x3 length vec3. This is now explicitly forbidden; you must pass at least a (0, 3) multidimensional array. Fixes cctbx#439.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a size (3,) array would have erroneously converted to a 0x3 length vec3.
This is now explicitly forbidden; you must pass at least a (0, 3) multidimensional array.
Fixes #439.