Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Registry against refl/expt files #650

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

ndevenish
Copy link
Collaborator

This was previously done implicitly, but only when dials_regression was present. This makes the test explicit, and works with dials-data (so that it will work on e.g. CI with restricted access to test cases).

ndevenish and others added 2 commits July 26, 2023 14:23
This was previously done implicitly, but only when dials_regression
was present. This makes the test explicit, and works with
dials-data (so that it will work on e.g. CI with restricted access
to test cases).
@ndevenish ndevenish enabled auto-merge (squash) July 26, 2023 13:26
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #650 (7aba9d4) into main (436a1b6) will decrease coverage by 0.30%.
Report is 1 commits behind head on main.
The diff coverage is 18.13%.

❗ Current head 7aba9d4 differs from pull request most recent head e831497. Consider uploading reports for the commit e831497 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
- Coverage   39.40%   39.11%   -0.30%     
==========================================
  Files         178      179       +1     
  Lines       15542    15757     +215     
  Branches     3004     3040      +36     
==========================================
+ Hits         6125     6164      +39     
- Misses       8836     9010     +174     
- Partials      581      583       +2     

@ndevenish ndevenish merged commit e9b88d2 into cctbx:main Jul 26, 2023
10 of 11 checks passed
toastisme pushed a commit to toastisme/dxtbx that referenced this pull request Jul 18, 2024
This was previously done implicitly, but only when dials_regression
was present. This makes the test explicit, and works with
dials-data (so that it will work on e.g. CI with restricted access
to test cases).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants