-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formats for the ELDICO ED-1 #682
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment. Very much based on FormatBrukerPhoton. Avoids BrukerImage for the same reason as for that class (https://github.com/cctbx/cctbx_project/issues/65) Unsure about gain and gonio angles still
There is still a question about potential image flips between the SFRM and CBF versions
- force pixel size - flip image in Y so it matches that from the CBFs
…ther types of images here
…umption that 1/3 is never right, invert that case to get 3.0, and therefore support old and new files within the calculation.
orientation for the test data sets recorded on the ED-1 prototype
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
- Coverage 42.62% 42.02% -0.61%
==========================================
Files 182 184 +2
Lines 15924 16160 +236
Branches 3056 3099 +43
==========================================
+ Hits 6788 6791 +3
- Misses 8510 8741 +231
- Partials 626 628 +2 |
graeme-winter
pushed a commit
that referenced
this pull request
Feb 5, 2024
Basic readers for Bruker Format-100 and miniCBF images from the ELDICO ED-1 instrument.
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
Basic readers for Bruker Format-100 and miniCBF images from the ELDICO ED-1 instrument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format classes for data from the ELDICO ED-1 instrument, that may be in either Bruker format or miniCBF format.