Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formats for the ELDICO ED-1 #682

Merged
merged 16 commits into from
Jan 26, 2024
Merged

Formats for the ELDICO ED-1 #682

merged 16 commits into from
Jan 26, 2024

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Jan 22, 2024

Format classes for data from the ELDICO ED-1 instrument, that may be in either Bruker format or miniCBF format.

dagewa and others added 16 commits September 29, 2023 14:54
…ment.

Very much based on FormatBrukerPhoton. Avoids BrukerImage for the same
reason as for that class (https://github.com/cctbx/cctbx_project/issues/65)

Unsure about gain and gonio angles still
There is still a question about potential image flips between the
SFRM and CBF versions
- force pixel size
- flip image in Y so it matches that from the CBFs
…umption

that 1/3 is never right, invert that case to get 3.0, and therefore support
old and new files within the calculation.
orientation for the test data sets recorded on the ED-1 prototype
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 217 lines in your changes are missing coverage. Please review.

Comparison is base (dbd7ede) 42.62% compared to head (a557185) 42.02%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   42.62%   42.02%   -0.61%     
==========================================
  Files         182      184       +2     
  Lines       15924    16160     +236     
  Branches     3056     3099      +43     
==========================================
+ Hits         6788     6791       +3     
- Misses       8510     8741     +231     
- Partials      626      628       +2     

@dagewa dagewa merged commit 33a7202 into cctbx:main Jan 26, 2024
12 of 13 checks passed
graeme-winter pushed a commit that referenced this pull request Feb 5, 2024
Basic readers for Bruker Format-100 and miniCBF images from the ELDICO ED-1 instrument.
toastisme pushed a commit to toastisme/dxtbx that referenced this pull request Jul 18, 2024
Basic readers for Bruker Format-100 and miniCBF images from the ELDICO ED-1 instrument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants