FormatSMVTimePix_SU mask out central cross of virtual pixels
#683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
got reasonable intensity values, they do not correctly represent the reflection profiles. This also means handling between the 4- panel 512*512 pixel model (which excludes the edge pixels between the panels) and the 516*516 pixel model are now consistent. Both versions now exclude these special edge pixels.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 42.62% 42.57% -0.06%
==========================================
Files 182 182
Lines 15924 15950 +26
Branches 3056 3059 +3
==========================================
+ Hits 6788 6791 +3
- Misses 8510 8532 +22
- Partials 626 627 +1 |
graeme-winter
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Always mask out the central cross of pixels, as even if these have got reasonable intensity values, they do not correctly represent the reflection profiles. This also means handling between the 4- panel 512*512 pixel model (which excludes the edge pixels between the panels) and the 516*516 pixel model are now consistent. Both versions now exclude these special edge pixels.
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
…#683) * Always mask out the central cross of pixels, as even if these have got reasonable intensity values, they do not correctly represent the reflection profiles. This also means handling between the 4- panel 512*512 pixel model (which excludes the edge pixels between the panels) and the 516*516 pixel model are now consistent. Both versions now exclude these special edge pixels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One version of this format has a 516×516 pixel data array, where the central 6-pixel wide cross has been reconstructed from raw pixels that are three times wider than a normal pixel. Absent truthful handling for such a case (dials/dials#2585), we simply mask these pixels. This means handling is consistent with the 512×512 pixel version, where the detector is split into quadrant panels, which exclude the wider pixels.