-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan from dict fix #693
Scan from dict fix #693
Conversation
…t if all properties already have the expected length.
59dbb39
to
5beec31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can confirm this fixes the re-opened dials/dials#2606. I have not considered other aspects in this review
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 42.40% 42.44% +0.03%
==========================================
Files 186 186
Lines 16358 16408 +50
Branches 3121 3141 +20
==========================================
+ Hits 6937 6964 +27
- Misses 8789 8805 +16
- Partials 632 639 +7 |
* Fixed bug in `Scan.from_dict` where some properties were not correctly parsed.
This fixes three bugs:
ScanFactory.from_dict
before being passed toScan.from_dict
oscillation_width
was not correctly converted to radians inScan.to_dict
when dealing with Scans with only one imageThe first two are tested in
test_scan_properties_from_dict
. The third was picked up intest_experimentlist_dumper_dump_formats
andtest_experimentlist_dumper_dump_scan_varying
.