Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recently added ESRFJF4M format class #707

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

jbeilstenedmands
Copy link

@jbeilstenedmands jbeilstenedmands commented Mar 11, 2024

Avoids matching to dataset h5 files, as evidenced by recently failing dials test.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 42.15%. Comparing base (1da5d45) to head (2f7ef3c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   42.16%   42.15%   -0.01%     
==========================================
  Files         188      188              
  Lines       16762    16764       +2     
  Branches     3195     3196       +1     
==========================================
  Hits         7067     7067              
- Misses       9051     9052       +1     
- Partials      644      645       +1     

@jbeilstenedmands jbeilstenedmands merged commit 78147cc into main Mar 11, 2024
20 checks passed
@jbeilstenedmands jbeilstenedmands deleted the fix_JF4Mformat branch March 11, 2024 20:12
toastisme pushed a commit to toastisme/dxtbx that referenced this pull request Jul 18, 2024
Fix recently added JF4M format class. Avoids matching to dataset h5 files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants