Switch linting/formatting to ruff #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except clang-format, will do separately.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
=======================================
Coverage 41.76% 41.76%
=======================================
Files 188 188
Lines 16877 16877
Branches 3233 3233
=======================================
Hits 7048 7048
- Misses 9174 9179 +5
+ Partials 655 650 -5 |
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
* Move isort,black,flake8 to ruff * Update formatting to latest black style before switch * Lint fixes, both manually and automatic (including unsafe fixes, manually checked)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Away from flake8/black. This is much faster, allows us to drop setup.cfg, gives us many more options for linting, and enables pre-commit to autofix many of the standard issues (only safe fixes are applied by default, however).
Our version of black in pre-commit was quite old, so a good chunk of these changes were from upgrading and running black first.