Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional methods for FormatISISSXD to extract data more efficiently. #743

Merged
merged 10 commits into from
Aug 12, 2024

Conversation

toastisme
Copy link
Contributor

This adds methods to FormatISISSXD for extracting data at the image and pixel level, where the time-of-flight dimension is flattened. This is required for visualisation purposes, and having methods at the format class level allows for data to be extracted more efficiently. Methods for getting the instrument name and proton charge are also added. The latter is required for scaling.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 12.19512% with 36 lines in your changes missing coverage. Please review.

Project coverage is 41.69%. Comparing base (4e46bec) to head (773e4a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   41.75%   41.69%   -0.07%     
==========================================
  Files         188      188              
  Lines       16880    16920      +40     
  Branches     3233     3240       +7     
==========================================
+ Hits         7049     7054       +5     
- Misses       9181     9216      +35     
  Partials      650      650              

@toastisme toastisme enabled auto-merge (squash) July 24, 2024 09:34
@toastisme toastisme disabled auto-merge July 24, 2024 14:28
@toastisme toastisme enabled auto-merge (squash) July 25, 2024 13:19
@dagewa dagewa disabled auto-merge July 30, 2024 13:37
@ndevenish ndevenish merged commit aebb3d9 into cctbx:main Aug 12, 2024
2 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants