FullCBFWriter: repair the panel shuffling bug (#745) #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
+ Coverage 41.54% 41.56% +0.02%
==========================================
Files 189 189
Lines 17060 17066 +6
Branches 3271 3273 +2
==========================================
+ Hits 7088 7094 +6
Misses 9318 9318
Partials 654 654 |
|
Oh I see, great find. Ok, I'd like to test this a bit on my side. Will be quick about it. |
phyy-nx
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Looks good. I tested it on the JF16M Zenodo deposition using dxtbx.image_average and got the same result (binary identical using diff). Thanks!
|
@phyy-nx Thank you very much for your review. |
ndevenish
added a commit
that referenced
this pull request
Aug 22, 2024
ndevenish
pushed a commit
that referenced
this pull request
Aug 22, 2024
|
I squashed the commit down on main :) |
Merged
DiamondLightSource-build-server
pushed a commit
to dials/dxtbx
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug reported in #745, which also contains test datasets.