Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i23 for run 4, 2024: row 21 of the modules has failed #754

Merged
merged 2 commits into from
Oct 15, 2024
Merged

i23 for run 4, 2024: row 21 of the modules has failed #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e62cfd5
i23 for run 4, 2024: row 21 of the modules has failed
graeme-winter Sep 8, 2024
44486ea
Rename newsfragments/XXX.misc to newsfragments/754.misc
DiamondLightSource-build-server Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/754.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
i23: mask row 21 completely for run 4, 2024
10 changes: 9 additions & 1 deletion src/dxtbx/format/FormatCBFMiniPilatusDLS12M.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,15 @@
cy = 97 # chip pixels y
dx = 7 # module gap size

if timestamp > calendar.timegm((2022, 7, 1, 0, 0, 0)):
if timestamp > calendar.timegm((2024, 9, 1, 0, 0, 0)):
# 2024 run 4
# modules @ row 22 column 1...5
if self._multi_panel:

Check warning on line 178 in src/dxtbx/format/FormatCBFMiniPilatusDLS12M.py

View check run for this annotation

Codecov / codecov/patch

src/dxtbx/format/FormatCBFMiniPilatusDLS12M.py#L178 

Added line #L178 was not covered by tests
for j in range(5):
detector[5 * 21 + j].add_mask(0, 0, nx, ny)

Check warning on line 180 in src/dxtbx/format/FormatCBFMiniPilatusDLS12M.py

View check run for this annotation

Codecov / codecov/patch

src/dxtbx/format/FormatCBFMiniPilatusDLS12M.py#L180 

Added line #L180 was not covered by tests
else:
detector[21].add_mask(0, 0, 5 * nx + 4 * dx, ny)
elif timestamp > calendar.timegm((2022, 7, 1, 0, 0, 0)):
# 2022 run 3
# Detector serviced by Dectris, no bad modules
pass
Expand Down
Loading