Add DB Schema #8

kratsg · 2017-10-25T00:34:08Z

2017-10-25T00:32:13.635925+00:00 app[api]: Deploy d76910e9 by user kratsg@gmail.com
2017-10-25T00:32:21.827208+00:00 app[web.1]: signsfive-api listening at http://[::]:54396
2017-10-25T00:32:21.989604+00:00 app[web.1]: Executing (default): SELECT 1+1 AS result
2017-10-25T00:32:21.999789+00:00 app[web.1]: {"name":"signsfive-api","hostname":"bb0310f8-0ef6-47f3-9534-c94b3fa172c9","pid":18,"level":30,"msg":"Database connection has been established successfully.","time":"2017-10-25T00:32:21.999Z","v":0}
2017-10-25T00:32:22.138772+00:00 heroku[web.1]: State changed from starting to up

we can definitely authenticate to the database correctly. This is a WIP and I should add the rest of the functionality soon.

kratsg · 2017-10-25T03:24:04Z

Progress so far:

all models added
reorganized code to make database definition look cleaner

correctly define associations for our models based on the lingo here: http://docs.sequelizejs.com/manual/tutorial/associations.html
complete validation definition of our models based on: http://docs.sequelizejs.com/manual/tutorial/models-definition.html#validations
describe steps to set up a sqlite3 database locally and have this set up so that we can quickly switch databases

meltedspork

How do you feel that in new (maybe next?) PR that we could use babel here so we can use ES2015+?

meltedspork · 2017-10-25T15:54:03Z

db/models/sign.js

+'use strict';
+module.exports = (sequelize, DataTypes) => {
+ var Sign = sequelize.define('Sign', {
+ name: DataTypes.STRING,


Do we need id in the sign model?

Sequelize will add this automatically when sync'ing the table (along with created/updated fields). We can be more explicit about this.

meltedspork · 2017-10-25T15:54:17Z

db/models/terminology.js

+'use strict';
+module.exports = (sequelize, DataTypes) => {
+ var Terminology = sequelize.define('Terminology', {
+ name: DataTypes.STRING,


Do we need id in the terminology model?

Sequelize will add this automatically when sync'ing the table (along with created/updated fields). We can be more explicit about this.

meltedspork · 2017-10-25T15:54:27Z

db/models/user.js

+'use strict';
+module.exports = (sequelize, DataTypes) => {
+ var User = sequelize.define('User', {
+ email: {


Do we need id in the user model?

Sequelize will add this automatically when sync'ing the table (along with created/updated fields). We can be more explicit about this.

meltedspork · 2017-10-25T15:55:22Z

db/models/introspect.js

+'use strict';
+module.exports = (sequelize, DataTypes) => {
+ var Introspect = sequelize.define('Introspect', {
+ name: DataTypes.STRING,


Do we need id in the introspect model?

Sequelize will add this automatically when sync'ing the table (along with created/updated fields). We can be more explicit about this.

kratsg · 2017-10-25T17:35:34Z

How do you feel that in new (maybe next?) PR that we could use babel here so we can use ES2015+?

Sure. Most of the files were generated by the sequelize-cli which just didn't directly support ES2015+ out of the box. For now, just to make sure things worked, I just did everything here in vanilla javascript with the ulterior goal to migrate.

meltedspork · 2017-10-25T19:22:55Z

Sure. Most of the files were generated by the sequelize-cli which just didn't directly support ES2015+ out of the box. For now, just to make sure things worked, I just did everything here in vanilla javascript with the ulterior goal to migrate.

That makes sense. We can keep everything vanilla JavaScript for sequelize

kratsg · 2017-11-08T03:08:19Z

Tables:

Author
Sign
Regions
Source
Category
Gloss

Changes:

Remove introspection table
Add Regions
Rename Terminology to Gloss
Add Source

Relationship overview:

Source.B2M(Gloss, ...)
Gloss.B2M(Source, ...)
Source.B2M(Cat, ...)
Sign.B2M(Cat, ...)
Cat.B2M(Source, ...)
Sign.B2M(Gloss, ...)
Sign.B2M(Region, ...)
Cat.B2M(Sign, ...)
Gloss.B2M(Gloss, gloss1)
Gloss.B2M(Gloss, gloss2)
Regions.B2M(Sign, ...)
Author.hasMany(Sign, ...) [author ID added to sign table]
Regions.hasMany(Author, ...) [region ID added to author table]

Design overview:

meltedspork · 2017-11-08T04:58:51Z

Lets fix the naming tables a bit with proper grammar -

Authors
Signs
Regions
Sources
Categories
Glosses

kratsg · 2017-11-21T22:18:32Z

SQL generated so far, but I will encode this into a migration soon...

Database: signsfive_dev
+-----------------+
|     Tables      |
+-----------------+
| Authors         |
| Categories      |
| Glosses         |
| Regions         |
| SequelizeMeta   |
| Signs           |
| Sources         |
| category_sign   |
| category_source |
| gloss_gloss     |
| gloss_sign      |
| gloss_source    |
| region_sign     |
+-----------------+

Executing (default): CREATE TABLE IF NOT EXISTS `Regions` (`id` INTEGER NOT NULL auto_increment , `name` VARCHAR(255), `loc` POINT, `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, PRIMARY KEY (`id`)) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `Regions` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `Authors`;
Executing (default): CREATE TABLE IF NOT EXISTS `Authors` (`id` INTEGER NOT NULL auto_increment , `email` VARCHAR(255), `username` VARCHAR(255), `auth0_id` VARCHAR(255), `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, `RegionId` INTEGER, PRIMARY KEY (`id`), FOREIGN KEY (`RegionId`) REFERENCES `Regions` (`id`) ON DELETE SET NULL ON UPDATE CASCADE) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `Authors` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `Categories`;
Executing (default): CREATE TABLE IF NOT EXISTS `Categories` (`id` INTEGER NOT NULL auto_increment , `name` VARCHAR(255), `description` TEXT, `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, PRIMARY KEY (`id`)) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `Categories` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `Glosses`;
Executing (default): CREATE TABLE IF NOT EXISTS `Glosses` (`id` INTEGER NOT NULL auto_increment , `name` VARCHAR(255), `description` TEXT, `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, PRIMARY KEY (`id`)) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `Glosses` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `Signs`;
Executing (default): CREATE TABLE IF NOT EXISTS `Signs` (`id` INTEGER NOT NULL auto_increment , `giphy_id` VARCHAR(255), `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, `AuthorId` INTEGER, PRIMARY KEY (`id`), FOREIGN KEY (`AuthorId`) REFERENCES `Authors` (`id`) ON DELETE SET NULL ON UPDATE CASCADE) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `Signs` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `Sources`;
Executing (default): CREATE TABLE IF NOT EXISTS `Sources` (`id` INTEGER NOT NULL auto_increment , `url` VARCHAR(255), `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, PRIMARY KEY (`id`)) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `Sources` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `category_source`;
Executing (default): CREATE TABLE IF NOT EXISTS `category_source` (`createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, `category_id` INTEGER , `source_id` INTEGER , PRIMARY KEY (`category_id`, `source_id`), FOREIGN KEY (`category_id`) REFERENCES `Categories` (`id`) ON DELETE CASCADE ON UPDATE CASCADE, FOREIGN KEY (`source_id`) REFERENCES `Sources` (`id`) ON DELETE CASCADE ON UPDATE CASCADE) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `category_source` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `category_sign`;
Executing (default): CREATE TABLE IF NOT EXISTS `category_sign` (`createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, `category_id` INTEGER , `sign_id` INTEGER , PRIMARY KEY (`category_id`, `sign_id`), FOREIGN KEY (`category_id`) REFERENCES `Categories` (`id`) ON DELETE CASCADE ON UPDATE CASCADE, FOREIGN KEY (`sign_id`) REFERENCES `Signs` (`id`) ON DELETE CASCADE ON UPDATE CASCADE) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `category_sign` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `gloss_source`;
Executing (default): CREATE TABLE IF NOT EXISTS `gloss_source` (`createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, `gloss_id` INTEGER , `source_id` INTEGER , PRIMARY KEY (`gloss_id`, `source_id`), FOREIGN KEY (`gloss_id`) REFERENCES `Glosses` (`id`) ON DELETE CASCADE ON UPDATE CASCADE, FOREIGN KEY (`source_id`) REFERENCES `Sources` (`id`) ON DELETE CASCADE ON UPDATE CASCADE) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `gloss_source` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `gloss_gloss`;
Executing (default): CREATE TABLE IF NOT EXISTS `gloss_gloss` (`createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, `gloss_id` INTEGER , `alt_gloss_id` INTEGER , PRIMARY KEY (`gloss_id`, `alt_gloss_id`), FOREIGN KEY (`gloss_id`) REFERENCES `Glosses` (`id`) ON DELETE CASCADE ON UPDATE CASCADE, FOREIGN KEY (`alt_gloss_id`) REFERENCES `Glosses` (`id`) ON DELETE CASCADE ON UPDATE CASCADE) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `gloss_gloss` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `region_sign`;
Executing (default): CREATE TABLE IF NOT EXISTS `region_sign` (`createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, `region_id` INTEGER , `sign_id` INTEGER , PRIMARY KEY (`region_id`, `sign_id`), FOREIGN KEY (`region_id`) REFERENCES `Regions` (`id`) ON DELETE CASCADE ON UPDATE CASCADE, FOREIGN KEY (`sign_id`) REFERENCES `Signs` (`id`) ON DELETE CASCADE ON UPDATE CASCADE) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `region_sign` FROM `signsfive_dev`
Executing (default): DROP TABLE IF EXISTS `gloss_sign`;
Executing (default): CREATE TABLE IF NOT EXISTS `gloss_sign` (`createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, `sign_id` INTEGER , `gloss_id` INTEGER , PRIMARY KEY (`sign_id`, `gloss_id`), FOREIGN KEY (`sign_id`) REFERENCES `Signs` (`id`) ON DELETE CASCADE ON UPDATE CASCADE, FOREIGN KEY (`gloss_id`) REFERENCES `Glosses` (`id`) ON DELETE CASCADE ON UPDATE CASCADE) ENGINE=InnoDB;
Executing (default): SHOW INDEX FROM `gloss_sign` FROM `signsfive_dev`

kratsg · 2017-11-21T23:04:47Z

kratsg · 2017-11-22T06:37:36Z

kratsg · 2017-11-22T07:04:07Z

To do:

determine if we should use scopes for sourcable models: gloss and sign. Could potentially combine into a single table with a foreign key that's joined on another table depending on the value of a column [see http://docs.sequelizejs.com/manual/tutorial/associations.html#scopes] -- see Understand scopes better for sequelize #12 for this.
fix up primary keys for relationship-relationship tables, specifically they should not have an id that's auto-incrementing, but a combined primary key -- fix up the migration here since we do not have a database yet.

kratsg · 2017-11-23T20:35:25Z

kratsg · 2017-11-23T20:35:49Z

@meltedspork time for you to look things over!

meltedspork · 2017-11-24T15:40:13Z

SWEET!!!!

…ique declarator

kratsg · 2017-11-27T01:43:37Z

@meltedspork approved offline.

meltedspork reviewed Oct 25, 2017

View reviewed changes

meltedspork force-pushed the master branch from 4a9ca54 to 09b35d2 Compare November 8, 2017 07:30

kratsg force-pushed the add/dbSchema branch from 9d01744 to 0137edb Compare November 23, 2017 20:22

kratsg changed the title ~~WIP: Add DB Schema~~ Add DB Schema Nov 23, 2017

kratsg force-pushed the add/dbSchema branch from 3812865 to 2cd1198 Compare November 25, 2017 01:29

kratsg added 13 commits November 26, 2017 19:40

add sequelize

a8fe808

add mysql backend

2f60e98

add authenticate method for testing the connection

b04ac48

create services/ folder. move logger and db to services

5a73763

add sequelize-cli

695427a

const, not var

60f69d9

add initial setup from cli

31fd227

update to point to models correctly

2bc5d09

add configs for sequelize

43965e7

remove db.js - use sequelize layout

d53fb5d

let's test that we can connect/authenticate

0a504ab

comment out authentication for right now

5d33487

update README

28fad80

kratsg added 26 commits November 26, 2017 19:42

update gloss

dd351a3

update region relationship

407cc59

fix up models to use associations correctly

1dc448e

add insructions for db dev in README

82d57b9

fix up typo in category_sign

03684e7

ignore DS_Store for mac

dd2905c

add migration to create author table

2ac8347

migration to create category table

9003200

add gloss migration

de17032

add region migration

bf1fe32

add sign migration

fb126a2

add source migration

7718b50

add author relationship to signs

a8b154d

add region relationship to authors

c45f98b

add gloss_gloss relationship

876ffe9

add gloss-source relationship

189ac71

add region-sign relationship

1cc4b87

add category-source relationship

5e74acf

add category-sign relationship

7df5770

add gloss-sign relationship

c828efd

add example of migration procedure for belongsToMany

a95c595

typo in README for code block

c83fad3

code block typo

b175d4e

add references for more info

f736ee9

sequelize-cli as a live dependency for running migrations

9ce6d9d

a composite primary key is already unique, no need to add an extra un…

90e1542

…ique declarator

kratsg force-pushed the add/dbSchema branch from 2cd1198 to 90e1542 Compare November 27, 2017 01:42

kratsg merged commit aa9cb55 into master Nov 27, 2017

kratsg deleted the add/dbSchema branch November 27, 2017 01:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DB Schema #8

Add DB Schema #8

kratsg commented Oct 25, 2017

kratsg commented Oct 25, 2017 •

edited

Loading

meltedspork left a comment

meltedspork Oct 25, 2017

kratsg Oct 25, 2017

meltedspork Oct 25, 2017

kratsg Oct 25, 2017

meltedspork Oct 25, 2017

kratsg Oct 25, 2017

meltedspork Oct 25, 2017

kratsg Oct 25, 2017

kratsg commented Oct 25, 2017

meltedspork commented Oct 25, 2017

kratsg commented Nov 8, 2017 •

edited

Loading

meltedspork commented Nov 8, 2017 •

edited

Loading

kratsg commented Nov 21, 2017 •

edited

Loading

kratsg commented Nov 21, 2017

kratsg commented Nov 22, 2017

kratsg commented Nov 22, 2017 •

edited

Loading

kratsg commented Nov 23, 2017

kratsg commented Nov 23, 2017

meltedspork commented Nov 24, 2017

kratsg commented Nov 27, 2017

Add DB Schema #8

Add DB Schema #8

Conversation

kratsg commented Oct 25, 2017

kratsg commented Oct 25, 2017 • edited Loading

meltedspork left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kratsg commented Oct 25, 2017

meltedspork commented Oct 25, 2017

kratsg commented Nov 8, 2017 • edited Loading

meltedspork commented Nov 8, 2017 • edited Loading

kratsg commented Nov 21, 2017 • edited Loading

kratsg commented Nov 21, 2017

kratsg commented Nov 22, 2017

kratsg commented Nov 22, 2017 • edited Loading

kratsg commented Nov 23, 2017

kratsg commented Nov 23, 2017

meltedspork commented Nov 24, 2017

kratsg commented Nov 27, 2017

kratsg commented Oct 25, 2017 •

edited

Loading

kratsg commented Nov 8, 2017 •

edited

Loading

meltedspork commented Nov 8, 2017 •

edited

Loading

kratsg commented Nov 21, 2017 •

edited

Loading

kratsg commented Nov 22, 2017 •

edited

Loading