Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨♻️ MQT Project Setup #23

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Conversation

burgholzer
Copy link
Member

This PR adds quite a couple of things to mqt-misim:

  • in order to make everything compile, this PR also subsumes added gates and definitions up to dimension 7 #21
  • properly integrates python bindings (from files of the binding to python #22) into the project. part of this was streamlining the existing CMake code
  • properly setting up Python packaging based on scikit-build-core (subsumes commited files for packaging #20)
  • update all pre-commit checks and add new ones related to the Python part of the project (subsumes ⬆️🪝 update pre-commit hooks #18)
  • adds a dependabot configuration to keep dependencies up to date
  • adds a very basic ReadTheDocs documentation setup (@KevinMTO please extend this in the future whenever you have time)
  • adopts the MQT reusable CI workflows that take care of everything from testing to coverage to linting to packaging
  • adds a release drafter configuration for automating release management
  • adds the infrastructure for python testing (@KevinMTO please consider writing some tests in the future for the Python part in test/python)

Signed-off-by: burgholzer <burgholzer@me.com>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 46.87500% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 74.2%. Comparing base (f775b69) to head (53a4ab8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #23     +/-   ##
=======================================
+ Coverage   67.2%   74.2%   +6.9%     
=======================================
  Files         16      13      -3     
  Lines       2270    1383    -887     
  Branches     377     264    -113     
=======================================
- Hits        1527    1027    -500     
+ Misses       743     356    -387     
Flag Coverage Δ
cpp 74.2% <46.8%> (?)
Files Coverage Δ
include/dd/Definitions.hpp 52.6% <ø> (ø)
include/dd/GateMatrixDefinitions.hpp 57.1% <40.0%> (ø)
include/dd/MDDPackage.hpp 80.6% <47.4%> (-1.0%) ⬇️

... and 4 files with indirect coverage changes

include/dd/MDDPackage.hpp Fixed Show fixed Hide fixed
include/dd/MDDPackage.hpp Fixed Show fixed Hide fixed
include/dd/MDDPackage.hpp Fixed Show fixed Hide fixed
include/dd/MDDPackage.hpp Fixed Show fixed Hide fixed
include/dd/MDDPackage.hpp Fixed Show fixed Hide fixed
include/dd/MDDPackage.hpp Fixed Show fixed Hide fixed
include/dd/MDDPackage.hpp Fixed Show fixed Hide fixed
include/dd/MDDPackage.hpp Fixed Show fixed Hide fixed
include/dd/MDDPackage.hpp Fixed Show fixed Hide fixed
include/dd/GateMatrixDefinitions.hpp Fixed Show fixed Hide fixed
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
include/dd/MDDPackage.hpp Fixed Show fixed Hide fixed
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinMTO everything looks good now expect the Python testing CI, because there literally is not a single proper python test so far. I had a pretty hard time figuring out which kind of input you expect to provide to the bound function.
Could you please add a proper test (can be extremely simple) here?

Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants