Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the way Linux wheels are built by cibuildwheel (in a manylinux docker container), environment varaiables are not passed down to the container. As a result the
CI
environment variable is not defined in the docker container, which is used to flip on theDEPLOY
CMake setting automatically.This has lead to manylinux wheels being built with
-march=native
that might produce errors likeIllegal instruction (core dumped)
when trying to import the respective packages.
This PR fixes this by making sure that
DEPLOY="ON"
within cibuildwheel.Fixes #375
Checklist: