Integrate Neutral Atom State Preparation #500
Conversation
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
…icly already in a depending target Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
ystade
added
feature
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
=======================================
+ Coverage 90.4% 90.5% +0.1%
=======================================
Files 87 91 +4
Lines 10052 10784 +732
Branches 1722 1831 +109
=======================================
+ Hits 9092 9770 +678
- Misses 960 1014 +54
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/na/nasp/CodeGenerator.cpp
Outdated
| (*it)->execute(); | ||
| } | ||
| } | ||
| for (std::uint16_t t = 1; t < result.numStages(); ++t) { |
Check failure
Code scanning / CodeQL
Comparison of narrow type with wide type in loop condition
src/na/nasp/CodeGenerator.cpp
Outdated
| std::vector<std::shared_ptr<Point>> loadEndPositions; | ||
| std::vector<std::shared_ptr<Point>> storeStartPositions; | ||
| std::vector<std::shared_ptr<Point>> storeEndPositions; | ||
| for (std::uint16_t i = 0; i < result.getStage(t).numQubits(); ++i) { |
Check failure
Code scanning / CodeQL
Comparison of narrow type with wide type in loop condition
src/na/nasp/Solver.cpp
Outdated
| model.eval(bv2int(stage.getQubit(i).getV(), true)).get_numeral_int()); | ||
| } | ||
| std::vector<Result::Gate> resultGates; | ||
| for (std::uint16_t i = 0; i < gates.size(); ++i) { |
Check failure
Code scanning / CodeQL
Comparison of narrow type with wide type in loop condition
src/na/nasp/Solver.cpp
Outdated
| model.eval(bv2int(stage.getQubit(i).getV(), true)).get_numeral_int()); | ||
| } | ||
| std::vector<Result::Gate> resultGates; | ||
| for (std::uint16_t i = 0; i < gates.size(); ++i) { |
Check failure
Code scanning / CodeQL
Comparison of narrow type with wide type in loop condition
|
@burgholzer I know that you removed the |
There was a problem hiding this comment.
Heads-up: I haven't really checked the implementations in all their detail. I mostly went through the tests and the interfaces in the headers and commented on aspects that I think could use some improvement from the using side of things.
Overall this looks really great though! Thanks for all the work!
I hope it doesn't take up too much time to address the points raised in the inline comments.
I think it's the right time to think about some of the interfaces now though. Otherwise, there will probably always be something more important to do instead of refactoring the code.
Signed-off-by: burgholzer <burgholzer@me.com>
There was a problem hiding this comment.
The unrelated error was fixed by #559, so this can finally go in.
Merging as soon as the test suite runs through 🚀
Description
It adds a new functionality to generate minimal schedules for preparing logical arrays on the neutral atom architecture.
Checklist: