Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 drop Python 3.8 support #515

Merged
merged 2 commits into from
Sep 7, 2024
Merged

🔥 drop Python 3.8 support #515

merged 2 commits into from
Sep 7, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Sep 5, 2024

Description

Python 3.8 will reach end of live in October 2024.
Qiskit is already issuing deprecation warnings since a couple of releases when using it on Python 3.8.
This PR officially drops support for Python 3.8 in mqt-qmap.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Sep 5, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file python Anything related to Python code labels Sep 5, 2024
@burgholzer burgholzer force-pushed the drop-python-38-support branch from 033f77f to 6c6c489 Compare September 5, 2024 15:49
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.6%. Comparing base (4d430cb) to head (bf8a6c6).
Report is 172 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #515     +/-   ##
=======================================
+ Coverage   90.4%   90.6%   +0.1%     
=======================================
  Files         87      87             
  Lines      10050   10046      -4     
  Branches    1716    1716             
=======================================
+ Hits        9090    9102     +12     
+ Misses       960     944     -16     
Flag Coverage Δ
cpp 90.3% <ø> (+0.1%) ⬆️
python 95.9% <100.0%> (ø)
Files with missing lines Coverage Δ
src/mqt/qmap/subarchitectures.py 95.4% <100.0%> (ø)

... and 3 files with indirect coverage changes

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer force-pushed the drop-python-38-support branch from 6c6c489 to 7994e56 Compare September 6, 2024 20:22
@burgholzer burgholzer enabled auto-merge (squash) September 6, 2024 23:16
@burgholzer burgholzer merged commit e958822 into main Sep 7, 2024
33 checks passed
@burgholzer burgholzer deleted the drop-python-38-support branch September 7, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant