fixed commit

[rjtch]

installed and caches steps for rust and rust

[rjtch]

This is in WiP and will be able to be merged soon.

[rjtch]

Sorrry @afrittoli i will rework it i changed everything because of this message ´taiki-e/install-action@protoc, dtolnay/rust-toolchain@beta, and swatinem/rust-cache@v2 are not allowed to be used in cdevents/sdk-rust. Actions in this workflow must be: within a repository owned by cdevents, created by GitHub, or matching the following: wagoid/commitlint-github-action@*.´ https://github.com/cdevents/sdk-rust/actions/runs/7576295830.

[afrittoli]

Sorrry @afrittoli i will rework it i changed everything because of this message ´taiki-e/install-action@protoc, dtolnay/rust-toolchain@beta, and swatinem/rust-cache@v2 are not allowed to be used in cdevents/sdk-rust. Actions in this workflow must be: within a repository owned by cdevents, created by GitHub, or matching the following: wagoid/commitlint-github-action@*.´ https://github.com/cdevents/sdk-rust/actions/runs/7576295830.

I can enable any action we need in the repo config, by default non-GitHub-maintained actions are disallowed for security reasons.

[afrittoli]

Thanks for the latest updates, it's looking good!

I think for the commit check to pass it would be easier if you squashed all commits to one, and updated the commit message. It would be nice if you could set the PT title and description to something with a bit more context too 🙏

[rjtch]

Thanks for the latest updates, it's looking good!

I think for the commit check to pass it would be easier if you squashed all commits to one, and updated the commit message. It would be nice if you could set the PT title and description to something with a bit more context too 🙏

yes sure i will

[davidB]

Maybe we could switch to mise (formerly rtx) to handle the installation on local env and on ci?

(in this PR or the next one)

[rjtch]

By default cd-event resctrict the use of public actions so they have to be added after some inspection. I use this to have as small image size as possible.

[davidB]

warning: with prettiers we should also provide the config for IDE/Editor to be in sync or for other linter, formatters. By example:

• print didn't agree with my VsCode auto-formatter (BetterTOML + EditorConfig) on toml
• rust code is formatted with cargo fmt (default rules)
• If we use megalinter/superlinter they already provide a bunch of yaml, json,... linter)

[rjtch]

my problem with mega-superlinter is the size of the image which are too big. One thing we could do would be to use prettier as pre-commit for linter all files and then remove this.

[davidB]

For my PR, more licenses will be needed (like CC0-1.0) some by lib used by the generator, some by delivered sdk.

Do you think, we should use the same rules for both (as the generator is not distributed)?

[rjtch]

yes but i don't know actually how the cd-event team would like to manage linsences but for me it is not a problem.