This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
issue#10 #20
Open
issue#10 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get latest updates from main repo
|
close pull request |
goneall
suggested changes
Jan 17, 2020
| @@ -149,6 +160,35 @@ | |||
| "id": "3T-SBOM-EMS-Artifact-Document-signature", | |||
| "reverseName": "document" | |||
| }, | |||
| { | |||
| "class": "ExternalDocumentRef", | |||
| "name": "identifier", | |||
There was a problem hiding this comment.
Changing identifier -> externalDocumentId would make this compatible with SPDX
| }, | ||
| { | ||
| "class": "ExternalDocumentRef", | ||
| "name": "namespace", |
There was a problem hiding this comment.
Just a note that this term is incompatible with SPDX which is spdxDocument. If this proposal is accepted, we should add an issue to SPDX 3.0 to change spdxDocument -> namespace.
| "package": "Artifact", | ||
| "id": "3T-SBOM-EMS-Artifact-ExternalDocumentRef-signature", | ||
| "reverseName": "document" | ||
| }, | ||
| { | ||
| "class": "AbstractArtifact", |
There was a problem hiding this comment.
propose adding one more field checksum with a type 3T-...Checksum and a multiplicity of 0..1. 2 reasons to add - checksums are much easier to generate than signatures and it would be compatible with SPDX.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10 (comment)