fix: apply account/region to more metrics #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeung-amzn
added
the
do-not-merge
echeung-amzn
force-pushed
the
more-regions
branch
3 times, most recently
from
09543f1
to
8e391ea
Compare
Merged
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
Pulling out irrelevant code cleanup from #544. Also clarifying in docs that cross-region alarms are not supported by CloudWatch. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
echeung-amzn
force-pushed
the
more-regions
branch
2 times, most recently
from
2b0c08b
to
f061978
Compare
echeung-amzn
force-pushed
the
more-regions
branch
from
f061978
to
3f16a10
Compare
echeung-amzn
force-pushed
the
more-regions
branch
from
3f16a10
to
092802d
Compare
| return metricAccount; | ||
| } | ||
|
|
||
| return; |
There was a problem hiding this comment.
What happens if the metricAccount is not defined? Do we want to return account in those cases or we default to not passing account (which resolves to same account)?
Same question for region below.
There was a problem hiding this comment.
If they're not explicitly declared, it should just inherit what the deployment environment context is (i.e. whatever the stack is in, like what a Metric would normally do if you don't pass in account or region).
ayush987goyal
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing a few misses from #533.
Also updates the test in
MonitoringFacade.test.tssince XAXR alarms aren't possible.Fixes #434, but only in cases where we can infer that the account/region is actually different from the construct scope to prevent unnecessary XAXR alarm errors.
Fixes #428, in cases where the account/region is actually different from the construct scope.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license