feat: option to configure partition with env var #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbergkvist
force-pushed
the
add-aws-cn-support
branch
from
711d2ef to
e099211
Compare
mbergkvist
force-pushed
the
add-aws-cn-support
branch
from
e099211 to
c107acd
Compare
kaizencc
requested changes
Mar 4, 2024
Absolutely. I'll see what I can do.
Of course. I don't know why I didn't add it in the first place 🤦 |
mbergkvist
force-pushed
the
add-aws-cn-support
branch
2 times, most recently
from
65ebea9 to
80a9e89
Compare
|
@kaizencc I've updated the documentation, I'm not a technical writer though so feel free to update it. I've also added test suites, I figured it would get good coverage by duplicating the current test suites that are relevant for the changes here, and tweaking them for the aws-cn case. |
mbergkvist
force-pushed
the
add-aws-cn-support
branch
from
8a0f88d to
423b59c
Compare
|
@kaizencc Is this ok to be merged? |
kaizencc
reviewed
Mar 18, 2024
kaizencc
changed the title
kaizencc
approved these changes
Mar 18, 2024
Adds support for deployment to aws-cn partition by checking an optional environemt variable, CDK_AWS_PARTITION. The partition is currently not available to the pipeline in the jobForDeploy, adding the environment variable is a non-breaking change to get the pipeline to deploy to aws-cn.
The github, runner-provided and stage-options tests are duplicated and modified for using the aws-cn partition for the pipeline. The difference between the snapshots for the test suites looks correct when reviewing.
mbergkvist
force-pushed
the
add-aws-cn-support
branch
from
e47f8be to
716f628
Compare
mbergkvist
force-pushed
the
add-aws-cn-support
branch
from
716f628 to
026b47a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for deployment to aws-cn partition by checking an optional environemt variable,
CDK_AWS_PARTITION. The partition is currently not available to the pipeline in thejobForDeploy, adding the environment variable is a non-breaking change to get the pipeline to deploy to aws-cn.This has been verified with stacks and nested stacks in multiple stages in aws-cn.
Fixes #820