clipdel: add -F to match literal instead of regex #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdown
reviewed
Nov 9, 2024
src/clipdel.c
Outdated
| struct clipdel_state *state = private; | ||
| int ret = regexec(&state->rgx, line, 0, NULL, 0); | ||
| int ret = state->literal_match |
There was a problem hiding this comment.
patch looks good, my only thought is that the nested ternary isn't the easiest to read. maybe just do it in two if branches? then you don't need to coerce to REG_NOMATCH, too.
this adds an -F flag similar to grep to allow matching literals instead of a regex. useful in scripting context where the script has a literal line to match against. using -F avoids having to escape troublesome regex characters.
N-R-K
force-pushed
the
literal-clipdel
branch
from
fc69ed0 to
97dace5
Compare
|
Oh, and sorry, could you add a test to tests/x_integration_tests? :-) |
|
Looks great, thank you! |
|
I had to change the shebang to |
|
oh, that path is wrong, it should be /usr/bin/env bash. let me fix that. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds an -F flag similar to grep to allow matching literals instead of a regex.
useful in scripting context where the script has a literal line to match against. using -F avoids having to escape troublesome regex characters.