ast: Add AST builder methods for datetime-related types and operators #57
Conversation
Signed-off-by: Patrick Jakubowski <patrick.jakubowski@strongdm.com>
| func Datetime(t time.Time) Node { | ||
| return Value(types.FromStdTime(t)) | ||
| } | ||
|
|
||
| func Duration(d time.Duration) Node { | ||
| return Value(types.FromStdDuration(d)) | ||
| } |
There was a problem hiding this comment.
It would be nice if these could take their counterparts from the types library like the other builder functions, but alas they cannot because the types types don't have the same underlying structure as the stdlib types.
I looked into making types.Datetime a wrapper around time.Time so that we could support both types as an argument here, but you end up giving types.Datetime at least one of the same footguns that time.Time has: the == operator does not return true if two instances represent the same moment of time in two different locations. Instead, you need to use the .Equal() method to resolve that.
That ugliness was enough to convince me that we should keep the simpler representation that we have now.
Issue #, if available: None
Description of changes: Add missing AST builder methods for datetime and duration literals as well as their associated methods.