Adding support for entity tags #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdisselkoen
approved these changes
Oct 15, 2024
shaobo-he-aws
approved these changes
Oct 16, 2024
|
Can we make sure to make the same change on |
Merged
Created here: #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Case
Entity tagging is new in Cedar 4.2.x, but CedarJava 4.2.x is not able to leverage it with the current Entity object and serializer.
Details
tagsfield toEntity.javato support entities with tagsEntitySerializer.javato make sure the tags field makes it across the JNI layer and into the AuthorizationRequest string we pass.executeJsonValidationTestTesting
testEntityWithUnknownTagtoEntityValidationTests.javaJSON_TEST_FILESthat tested e2e allowing an action contingent on a tag being present in the resource.