Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arbitrary to 1.3.2 #464

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Fix arbitrary to 1.3.2 #464

merged 2 commits into from
Nov 5, 2024

Conversation

shaobo-he-aws
Copy link
Contributor

@shaobo-he-aws shaobo-he-aws commented Nov 5, 2024

Issue #, if available:
Apparently 1.4 is a breaking change.

Description of changes:

Signed-off-by: Shaobo He <shaobohe@amazon.com>
@adpaco-aws
Copy link
Contributor

Would it make sense to commit the Cargo.lock file instead?

If we decided to go with this solution, could you attach an issue so we know the reason and keep track of the work to upgrade?

@cdisselkoen
Copy link
Contributor

Since this is a library, its Cargo.lock will not be respected by packages depending on this library. If 1.4 truly doesn't work with this code, I prefer the solution here, not (just) committing the Cargo.lock. I agree a comment would be great though.

@john-h-kastner-aws
Copy link
Contributor

Would it make sense to commit the Cargo.lock file instead?

I prefer the solution here, not (just) committing the Cargo.lock.

I think we agree that it makes sense to start committing Cargo.lock in this repository for the same reasons we commit it in the main cedar repo.

@shaobo-he-aws shaobo-he-aws merged commit 500e3b2 into main Nov 5, 2024
5 of 6 checks passed
@shaobo-he-aws shaobo-he-aws deleted the chore/shaobo/arbitrary branch November 5, 2024 18:30
shaobo-he-aws added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants