Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document vscode settings #479

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Document vscode settings #479

merged 2 commits into from
Nov 20, 2024

Conversation

john-h-kastner-aws
Copy link
Contributor

I was editing in a new workspace and had to remember that wanted these settings.

@john-h-kastner-aws
document vscode settings
f9cd0ab 
Signed-off-by: John Kastner <jkastner@amazon.com>
cdisselkoen
cdisselkoen approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@cdisselkoen cdisselkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just check-in a .vscode/settings.json with these settings?

@john-h-kastner-aws
Copy link
Contributor Author

john-h-kastner-aws commented Nov 20, 2024 •
edited
Loading

Should we just check-in a .vscode/settings.json with these settings?

I thought about it, but LEAN_LIB_DIR isn't the same for everyone. We could write a script to generate the settings, or commit just the linkedProjects setting, but it didn't feel worth the trouble.

@john-h-kastner-aws john-h-kastner-aws merged commit 5eb1d90 into main Nov 20, 2024
5 of 6 checks passed
@cdisselkoen cdisselkoen deleted the document-vscode-settings branch November 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaobo-he-aws shaobo-he-aws shaobo-he-aws approved these changes

@cdisselkoen cdisselkoen cdisselkoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-h-kastner-aws @cdisselkoen @shaobo-he-aws