Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in with a passkey through form autofill #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

truongnmt
Copy link

Why

Sign in with a passkey through form autofill. Make the transition from password to passkey-based authentication easier.

Ref:

What

  • use Conditional UI to include passkeys in autofill suggestions
  • load credential options on page load

Copy link
Contributor

@santiagorodriguez96 santiagorodriguez96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @truongnmt! Sorry for the delay in responding 😕

It's currently returning an error for me, but I like where this is going!

@@ -31,6 +36,37 @@ function callback(url, body) {
});
}

function getCredentialOptions() {
return _fetch("/session/options").then(function(response) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a 404 error because we are trying to fetch /session/options which does not exist. It seems that the idea behind this endpoint was to get a challenge from the server right? So that might mean that we will need some kind of Conditional UI endpoint that sets a challenge and return PublicKeyCredentialRequestOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants