[GH Action] Update release tags and commit SHAs for mocha #1817
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request involve updates to the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
.vitepress/constants/mocha_versions.js (1)
2-7: Review version naming consistencyThere are inconsistencies in the version naming patterns:
- app: clean semver (
v3.0.2)- core: includes Tendermint version (
v1.44.0-tm-v0.34.35)- node: includes test suffix (
v0.20.4-test2)Consider establishing and documenting a consistent version naming strategy across all components. This will help prevent confusion and make it easier to track dependencies.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.vitepress/constants/mocha_versions.js(1 hunks)
🔇 Additional comments (2)
.vitepress/constants/mocha_versions.js (2)
4-5: Verify core version tag and SHA existence
The core version has been bumped from v1.43.0-tm-v0.34.35 to v1.44.0-tm-v0.34.35. Let's verify this version exists.
✅ Verification successful
Core version tag and SHA verification successful
The tag v1.44.0-tm-v0.34.35 exists and correctly points to the SHA a1268f7ae3e688144a613c8a439dd31818aae07d. Both the tag and the commit SHA are valid in the celestia-core repository.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence of the core version tag and SHA
# Expected results: The tag and SHA should exist in the repository
# Check if the tag exists and matches the SHA
gh api repos/celestiaorg/celestia-core/git/refs/tags/v1.44.0-tm-v0.34.35 --jq '.object.sha' || echo "Tag not found"
# Verify the SHA exists
gh api repos/celestiaorg/celestia-core/git/commits/a1268f7ae3e688144a613c8a439dd31818aae07d --jq '.sha' || echo "SHA not found"
Length of output: 277
2-3: Verify app version tag and SHA existence
The app version has changed from v3.0.1-mocha to v3.0.2, dropping the -mocha suffix. Let's verify this version exists.
✅ Verification successful
Version tag and SHA verification successful
The version tag v3.0.2 and its corresponding SHA b24feac743182b33192d46ed42d8f89578c084ab exist in the celestia-app repository and are correctly matched. The removal of the -mocha suffix appears to be an intentional change in the versioning strategy.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence of the app version tag and SHA
# Expected results: The tag and SHA should exist in the repository
# Check if the tag exists and matches the SHA
gh api repos/celestiaorg/celestia-app/git/refs/tags/v3.0.2 --jq '.object.sha' || echo "Tag not found"
# Verify the SHA exists
gh api repos/celestiaorg/celestia-app/git/commits/b24feac743182b33192d46ed42d8f89578c084ab --jq '.sha' || echo "SHA not found"
Length of output: 262
| "node-latest-tag": "v0.20.4-test2", | ||
| "node-latest-sha": "774be14be2debe5f77ce7f37424e8a074b357b13", |
There was a problem hiding this comment.
💡 Codebase verification
Version tag v0.20.4-test2 appears to be non-standard and should be updated
The repository shows that v0.20.4 is the latest production release, with standard variants being:
v0.20.4(main release)v0.20.4-mochav0.20.4-arabica
The current v0.20.4-test2 tag is not aligned with the versioning pattern used in the repository and should be updated to use one of the standard version tags.
- Consider updating to either
v0.20.4,v0.20.4-mocha, orv0.20.4-arabicabased on your requirements - The SHA
774be14be2debe5f77ce7f37424e8a074b357b13exists but should be referenced with the correct version tag
🔗 Analysis chain
Verify node version tag and SHA existence, and flag potential testing version
The node version has changed from v0.20.4-mocha to v0.20.4-test2, which suggests this might be a testing version. This needs verification.
The -test2 suffix suggests this might be a testing version. Please confirm if this is intentional or if we should be using a production release version instead.
Let me gather more information about this version tag to understand its context better.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence of the node version tag and SHA
# Expected results: The tag and SHA should exist in the repository
# Check if the tag exists and matches the SHA
gh api repos/celestiaorg/celestia-node/git/refs/tags/v0.20.4-test2 --jq '.object.sha' || echo "Tag not found"
# Verify the SHA exists
gh api repos/celestiaorg/celestia-node/git/commits/774be14be2debe5f77ce7f37424e8a074b357b13 --jq '.sha' || echo "SHA not found"
Length of output: 271
Script:
#!/bin/bash
# Check the commit message and details for this SHA to understand the context
gh api repos/celestiaorg/celestia-node/git/commits/774be14be2debe5f77ce7f37424e8a074b357b13 --jq '.commit.message'
# Let's also check if there are any related production versions around this timeframe
gh api repos/celestiaorg/celestia-node/git/refs/tags | jq -r '.[].ref' | grep -E 'v0.20.[0-9]+$|v0.20.[0-9]+-[^test]'
Length of output: 894
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit