-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/python #133
fix/python #133
Conversation
jcelerier
commented
Jan 14, 2025
- python: build fixes
- python: start adding api configurations
Thanks! That clears the previous errors but looks like I'm missing a boost lib (I have boost 1.87.0 installed from brew):
|
boost/variant2 has been there for many releases, I'd assume that it is getting an older version from somewhere on your hard drive. Did you try |
Overriding with However, I'm now encountering another dependency issue:
I tried adding a directive to CMakeLists as in here - does not seem to make a difference. |
for this last one it's strange, CMake should download it on its own. It does when I test on Linux. will try on mac later. |
Got a successfull build with this change: diff --git a/bindings/python/CMakeLists.txt b/bindings/python/CMakeLists.txt
index f914daa..58d2334 100644
--- a/bindings/python/CMakeLists.txt
+++ b/bindings/python/CMakeLists.txt
@@ -12,5 +12,16 @@ FetchContent_Declare(
)
FetchContent_MakeAvailable(nanobind)
+
+FetchContent_Declare(
+ readerwriterqueue
+ GIT_REPOSITORY https://github.com/cameron314/readerwriterqueue
+ GIT_TAG master
+)
+
+FetchContent_MakeAvailable(readerwriterqueue)
+
+
nanobind_add_module(pylibremidi pylibremidi.cpp)
target_link_libraries(pylibremidi PUBLIC libremidi)
+target_include_directories(pylibremidi PUBLIC SYSTEM $<BUILD_INTERFACE:${readerwriterqueue_SOURCE_DIR}>) |
ahh I see ! this code is already in libremidi but right now it only triggered on linux : https://github.com/celtera/libremidi/blob/master/cmake/libremidi.deps.cmake#L38 will just enable it unconditonally |