Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

add HealthEndpoints map as public #881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sergeylanzman
Copy link

add public HealthEndpoints for set custom Health urls

@rakyll
Copy link
Contributor

rakyll commented Aug 24, 2018

We unfortunately need to finalize census-instrumentation/opencensus-specs#151 before throwing new APIs to this problem.

@semistrict
Copy link
Contributor

@sergeylanzman could you explain a bit what prompted this change? what problem are you experiencing?

@sergeylanzman
Copy link
Author

@Ramonza
Sometimes application have health check on custom url not only "/healthz". Sometime health check intergrade from internal framework and more complicate(include check connection to DB, important services and etc). I think it's not relevant for tracing and need "clean" from tracing data/statistics.
This PR add support options for add/replace other options for health check for delete from tracing data

@sergeylanzman
Copy link
Author

sergeylanzman commented Aug 24, 2018

I think better solution create method "SetUntraceableEndpoints" and set internal map with endpoints.

@semistrict
Copy link
Contributor

What about having a per-path trace.Sampler as a map[string]trace.Sampler field on ochttp.Handler?

@rakyll
Copy link
Contributor

rakyll commented Sep 18, 2018

Can we achieve the blacklisting functionality via #869 (comment)?

We can return a NeverSample for health endpoints.

@rakyll
Copy link
Contributor

rakyll commented Sep 21, 2018

Once #924 is merged, I will create a ochttp/ochttputil package with some filter implementations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants