Multiple RPC endpoint support #2394

sophialittlejohn · 2024-08-20T19:57:33Z

Description

This pull request...

use the provider from getDefaultNetwork for centrifuge-react connectors
clean up leftover from goerli
fix warnings in console
fix start script in main package.json
accepts a comma separated list of rpc urls for polkadot and connects to the first healthy one
upgrades ethersjs to v6

2164

Approvals

Dev

Screenshots

Impact

…ter network

…twork

socket-security · 2024-08-20T19:58:57Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher

View full report↗︎

socket-security · 2024-08-20T19:59:01Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

github-actions · 2024-08-20T20:01:35Z

PR deployed in Google Cloud
URL: https://pr2394-app-ff-production.k-f.dev
Commit #: b24b6b3
To access the functions directly check the corresponding deploy Action

github-actions · 2024-08-20T20:01:37Z

PR deployed in Google Cloud
URL: https://app-pr2394.k-f.dev
Commit #: b24b6b3
To access the functions directly check the corresponding deploy Action

…r for more reliable rpc connections

onnovisser · 2024-08-29T10:40:47Z

centrifuge-react/src/components/WalletProvider/WalletProvider.tsx

-      (cachedProviders[chainId] = new JsonRpcProvider((evmChains as any)[chainId].urls[0], chainId))
-    )
+  async function findHealthyProvider(chainId: number, urls: string[]): Promise<JsonRpcProvider> {
+    for (const url of urls) {


Would use a Promise.any here

onnovisser · 2024-08-29T10:43:07Z

centrifuge-react/src/components/WalletProvider/WalletProvider.tsx

+    if (!cachedProviders.has(chainId)) {
+      findHealthyProvider(chainId, urls).catch(console.error)
+    }
+    return cachedProviders.get(chainId) || new JsonRpcProvider(urls[0], chainId)


with findHealthyProvider being async, this may return a new JsonRpcProvider multiple times and not garantee that it's healthy

I've changed the implementation to now use ethers getDefaultProvider() its, much cleaner and doesn't require the manual work from before

onnovisser · 2024-09-06T13:00:15Z

centrifuge-app/src/utils/tinlake/useTinlakeBalances.ts

  const calls: EvmMulticallCall[] = []
-  const toTokenBalance = (val: BigNumber) => new TokenBalance(val.toString(), 18)
-  const toCurrencyBalance = (val: BigNumber) => new CurrencyBalance(val.toString(), 18)
+  const toTokenBalance = (val: BigInt) => new TokenBalance(val.toString(), 18)


BigInt as a type has to be lowercase everywhere

onnovisser · 2024-09-06T13:01:55Z

centrifuge-js/src/CentrifugeBase.ts

+  }
+
+  private async findHealthyWs(): Promise<string | null> {
+    for (const url of this.rpcEndpoints) {


would use Promise.any here

onnovisser · 2024-09-06T13:03:29Z

centrifuge-js/src/CentrifugeBase.ts

+        clearTimeout(timer)
+        ws.close()
+        console.log(`Connection to ${url} failed`)
+        resolve(false)


if using Promise.any above, you can reject here instead

onnovisser · 2024-09-06T13:10:48Z

centrifuge-js/src/CentrifugeBase.ts

@@ -295,19 +296,69 @@ type Events = ISubmittableResult['events']

 const txCompletedEvents: Record<string, Subject<Events>> = {}
 const blockEvents: Record<string, Observable<Events>> = {}
+let parachainUrlCache: string | null = null


this won't work if there's different instances of the Centrifuge class. It's why the above caches are keyed by parachain url. I think it would be better to keep this as a property on the class. It would need to be copied over when the instance gets cloned though, like in Centrifuge->connect()

I agreed initially that the variable should be stored as a class property, but I noticed in doing so that the url is actually not cached at all and each time the instance is recreated the class property loses it's value. Like this we can store the value across instances which IMO is what we want for this feature instead of constantly opening a ws to check it's health and closing it again. Like this the cached url will only be reset when the page reloads and we can limit the number of ws opening requests to max as many urls as we have

what about making this a Set reachableParachainUrls? Then when getting the cached url, it can check which of the config urls is in the set. Then it still works if there's multiple instances of Centrifuge with different configs

onnovisser · 2024-09-06T13:16:29Z

centrifuge-js/src/CentrifugeBase.ts

@@ -459,7 +510,13 @@ export class CentrifugeBase {
        }),
        tap((result) => {


The tap callback can be an async function and then this.getTxCompletedEvents() can simply be awaited

onnovisser · 2024-09-06T13:17:17Z

centrifuge-js/src/CentrifugeBase.ts

+            from(this.getTxCompletedEvents())
+              .pipe(take(1))
+              .subscribe((subject) => {
+                subject.next(result.events)
+              })


Suggested change

from(this.getTxCompletedEvents())

.pipe(take(1))

.subscribe((subject) => {

subject.next(result.events)

})

(await this.getTxCompletedEvents()).next(result.events)

onnovisser · 2024-09-06T13:18:29Z

centrifuge-js/src/modules/liquidityPools.ts

@@ -373,7 +381,7 @@ export function getLiquidityPoolsModule(inst: Centrifuge) {
        ...(currencies.flatMap((currency) => ({
          target: poolManager,
          call: ['function assetToId(address) view returns (uint128)', currency.address],
-          returns: [[`currencyNeedsAdding[${currency.address}]`, (id: BigNumber) => id.isZero()]],
+          returns: [[`currencyNeedsAdding[${currency.address}]`, (id: BigInt) => id === BigInt(0)]],


Suggested change

returns: [[`currencyNeedsAdding[${currency.address}]`, (id: BigInt) => id === BigInt(0)]],

returns: [[`currencyNeedsAdding[${currency.address}]`, (id: bigint) => id === 0n]],

onnovisser · 2024-09-06T13:19:37Z

centrifuge-js/src/modules/tinlake.ts

@@ -94,6 +93,7 @@ export function getTinlakeModule(inst: Centrifuge) {
  ) {
    const [tranche] = args
    return pending(
+      // @ts-ignore


what are all these errors saying?? 😅😅😅

The types just weren't inferred properly by the connected contract. When using the the ethers Contract directly the methods on the contract are not type checked, but when using a connected contract the are type check even though the method types seem to be non-inferable from the ABI.

onnovisser · 2024-09-20T08:26:46Z

centrifuge-js/src/CentrifugeBase.ts

+    if (parachainUrlCache.values().next().value) {
+      return parachainUrlCache.values().next().value


Suggested change

if (parachainUrlCache.values().next().value) {

return parachainUrlCache.values().next().value

const match = this.rpcEndpoints.find(url => parachainUrlCache.has(url))

if (match) {

return match

onnovisser · 2024-09-20T08:41:10Z

@sophialittlejohn Looking good! One last comment.

sophialittlejohn added 7 commits August 19, 2024 19:14

Switch out JSON provider for default provider to auto switch to a bet…

4654b18

…ter network

Remove references to goerli

d9f728a

Clean up

af8ff3c

Use JsonRpcProvider as fallback if defaultprovider doesn't support ne…

891e249

…twork

Fix console warnings

eab7786

Fix start script in main package

1493e33

Clean up

6b9dc81

sophialittlejohn added 4 commits August 26, 2024 19:57

Upgrade ethersjs

dd9ae1f

Do manual health check on rpcs instead of relying on getDefaultBrowse…

ae84511

…r for more reliable rpc connections

Fix ts error

a214de9

Fix more type errros from upgrade

091a710

onnovisser reviewed Aug 29, 2024

View reviewed changes

sophialittlejohn added 7 commits August 29, 2024 13:16

Add connection checks to centrifuge base before connecting to parachain

a7ef87a

Merge branch 'main' of github.com:centrifuge/apps into default-provider

1551fc6

Clean up substrate network detection

f973f50

Fix event parsing

470a409

Add tenderly node rpc key

6ff7e7c

Enable getDefaultProvider for evm instead of manual implementation

bb8c0cf

Merge branch 'main' of github.com:centrifuge/apps into default-provider

2566ad7

onnovisser reviewed Sep 6, 2024

View reviewed changes

sophialittlejohn marked this pull request as draft September 9, 2024 13:05

sophialittlejohn added 5 commits September 9, 2024 10:58

Merge branch 'main' of github.com:centrifuge/apps into default-provider

6cf73e0

Replace BigInt with bigint

c3cf7c8

Update imports

a5a0c56

Clean up for centrifuge base

b050d4f

Clean up

e8a6074

sophialittlejohn changed the title ~~Use ethers default provider to auto switch to the best rpc network~~ Multiple RPC endpoint support Sep 13, 2024

sophialittlejohn added 5 commits September 16, 2024 10:10

Merge branch 'main' of github.com:centrifuge/apps into default-provider

e8a66c1

Remove outdated eth-permit in favor of custom code

42ebed4

Fix typescript errors in tinlake

3126dc5

Merge branch 'main' of github.com:centrifuge/apps into default-provider

be6b4cf

Use set for parachain url cache

5ca0a25

sophialittlejohn marked this pull request as ready for review September 16, 2024 22:13

sophialittlejohn requested a review from onnovisser September 16, 2024 22:13

onnovisser reviewed Sep 20, 2024

View reviewed changes

sophialittlejohn added 2 commits October 7, 2024 13:00

Merge branch 'main' of github.com:centrifuge/apps into default-provider

ea806c3

Match with rpc endpoints

713e77c

sophialittlejohn requested a review from onnovisser October 7, 2024 19:29

Fix typo

85efdea

sophialittlejohn requested review from onnovisser and removed request for onnovisser October 10, 2024 21:48

onnovisser approved these changes Oct 16, 2024

View reviewed changes

sophialittlejohn added 2 commits October 16, 2024 11:23

Merge branch 'main' of github.com:centrifuge/apps into default-provider

7226612

Fix import from ethers

b24b6b3

sophialittlejohn enabled auto-merge (squash) October 16, 2024 20:11

sophialittlejohn merged commit da791ea into main Oct 16, 2024
13 checks passed

sophialittlejohn deleted the default-provider branch October 16, 2024 20:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple RPC endpoint support #2394

Multiple RPC endpoint support #2394

sophialittlejohn commented Aug 20, 2024 •

edited

Loading

socket-security bot commented Aug 20, 2024 •

edited

Loading

socket-security bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

onnovisser Aug 29, 2024

onnovisser Aug 29, 2024

sophialittlejohn Sep 5, 2024

onnovisser Sep 6, 2024

onnovisser Sep 6, 2024

onnovisser Sep 6, 2024

onnovisser Sep 6, 2024 •

edited

Loading

sophialittlejohn Sep 11, 2024

onnovisser Sep 12, 2024 •

edited

Loading

onnovisser Sep 6, 2024

onnovisser Sep 6, 2024

onnovisser Sep 6, 2024

onnovisser Sep 6, 2024

sophialittlejohn Sep 16, 2024

onnovisser Sep 20, 2024

onnovisser commented Sep 20, 2024

		@@ -459,7 +510,13 @@ export class CentrifugeBase {
		}),
		tap((result) => {

	returns: [[`currencyNeedsAdding[${currency.address}]`, (id: BigInt) => id === BigInt(0)]],
	returns: [[`currencyNeedsAdding[${currency.address}]`, (id: bigint) => id === 0n]],

		if (parachainUrlCache.values().next().value) {
		return parachainUrlCache.values().next().value

-    if (parachainUrlCache.values().next().value) {
-      return parachainUrlCache.values().next().value
+    const match = this.rpcEndpoints.find(url => parachainUrlCache.has(url))
+    if (match) {
+      return match

Multiple RPC endpoint support #2394

Multiple RPC endpoint support #2394

Conversation

sophialittlejohn commented Aug 20, 2024 • edited Loading

Description

Approvals

Screenshots

Impact

socket-security bot commented Aug 20, 2024 • edited Loading

socket-security bot commented Aug 20, 2024 • edited Loading

github-actions bot commented Aug 20, 2024 • edited Loading

github-actions bot commented Aug 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

onnovisser Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

onnovisser Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

onnovisser commented Sep 20, 2024

sophialittlejohn commented Aug 20, 2024 •

edited

Loading

socket-security bot commented Aug 20, 2024 •

edited

Loading

socket-security bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

onnovisser Sep 6, 2024 •

edited

Loading

onnovisser Sep 12, 2024 •

edited

Loading