rbd: add ReadIterate implementing rbd_read_iterate2 #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comments above Read and Write were very old and not up to our current standards. Update them to be accurate and note that the offset internal to the image type is not concurrency safe. This also cleans up some old and unhelpful todos. Signed-off-by: John Mulligan <jmulligan@redhat.com>
The read_iterate2 call walks over the content of the image calling the callback for each data region. It is documented to have the ability to detect holes by setting the data pointer to null when the region is a hole. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
I expect this to fail. I don't expect to return to this until after the new year. :-D |
|
Abandoning PR. See issue #279 for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incomplete/experimental.
Checklist