Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Almost never-ending stream of stored anchors #2942

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

ukstv
Copy link
Contributor

@ukstv ukstv commented Sep 11, 2023

One-line change to make it never-ending:

gt = undefined // instead of return

@linear
Copy link

linear bot commented Sep 11, 2023

CDB-2741 Move resume part 1

Move resume part 1: change internals of resumeRunningStatesFromAnchorRequestStore so that the storage is treated as a never-ending ReadableStream.

Copy link
Contributor

@stbrody stbrody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -81,7 +76,6 @@ export class AnchorResumingService {
async close(): Promise<void> {
this.logger.debug('Closing AnchorResumingService')
this.#shouldBeClosed = true
this.resumeQ.clear()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@ukstv ukstv enabled auto-merge (squash) September 13, 2023 11:16
@ukstv ukstv merged commit e786c5a into develop Sep 13, 2023
2 checks passed
@ukstv ukstv deleted the feature/cdb-2741-move-resume-part-1 branch September 13, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants