chore : cat no console es lint rule added to pkgs with minimal/no changes #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samika98
changed the title
samika98
commented
Dec 7, 2023
| @@ -9,10 +9,14 @@ import { KeyringPair } from '@polkadot/keyring/types' | |||
| import { DispatchError } from '@polkadot/types/interfaces' | |||
| import { ITuple } from '@polkadot/types/types' | |||
| import { SubmittableExtrinsic } from '@polkadot/api/promise/types' | |||
| import { LoggerProvider } from '@ceramicnetwork/common' | |||
There was a problem hiding this comment.
Code Change here, in this file
samika98
commented
Dec 7, 2023
| @@ -1,11 +1,14 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| import { IpfsDaemon } from '../ipfs-daemon.js' | |||
| import { LoggerProvider } from '@ceramicnetwork/common' | |||
There was a problem hiding this comment.
Code change here, in this file. Let me know if we want to keep console.log in the http-client library, or changing it with the logger is better
|
Changes are mostly in the eslint file. There are 2 code changes in the PR, they are marked with comments for easier reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
es-lint rule for no direct access to console added. This will deny direct access to console from the code.
This PR includes packages in js-ceramic codebase that required minimal changes.
PRs for this are broken down into 3 PRS :
How Has This Been Tested?
Ran npm run lint on the packages where this rule has been added and corrected code that was not following the standard.
PR checklist
Before submitting this PR, please make sure:
References:
https://eslint.org/docs/latest/rules/no-console -- es lint rule for denying direct access to console