fix: unique metadata is not properly typed as a Uint8Array #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This test will fail without this change. |
ukstv
approved these changes
Feb 16, 2024
|
@dbcfd I'm confused why this PR was opened when we already had another PR with this same change in flight? #3141 I'd still really like to understand how and why we are winding up with data that isn't in the format we are expecting. I'm worried that this approach is papering over the symptoms rather than addressing the real source of the bug - which is whatever is generating data that doesn't have |
is it possible then that the Ceramic rust client isn't constructing/serializing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.