feat: Start up Node Metrics publishing after the Model becomes available locally #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbrody
force-pushed
the
wait-for-model-aes-232-new-approach
branch
from
1005a79 to
25ceded
Compare
stbrody
force-pushed
the
wait-for-model-aes-232-new-approach
branch
from
25ceded to
f5eaffd
Compare
stbrody
force-pushed
the
wait-for-model-aes-232-new-approach
branch
from
f5eaffd to
fcb5062
Compare
gvelez17
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New approach instead of #3265.
Now we start a background job that waits forever for the NodeMetrics model to be synced (using exponential backoff, maxing out at checking once per minute). If the model never becomes available, that job will keep checking for the Model once per minute, and will log an error once every 5 minutes. If the model ever becomes available, however, it will start up the NodeMetrics publishing subsystem at that point and the background task stops.