test: Unskip a flaky feed API test #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbrody
reviewed
Jul 29, 2024
| @@ -114,14 +113,14 @@ describe('Ceramic feed', () => { | |||
| return emissions.length >= 4 // Recon gives you more events :( | |||
| }, 5000) | |||
| // model.create | |||
| expect(emissions[0].commitId).toEqual(model.allCommitIds[0]) | |||
| expect(String(emissions[0].commitId)).toEqual(String(model.allCommitIds[0])) | |||
There was a problem hiding this comment.
hmm, can you explain what was going wrong here and why casting to a string prevents the stack overflow?
There was a problem hiding this comment.
That is an experimental (let me be honest here) approach based on some previous experience. Loong time ago we saw something similar with Jest unable in some cases to correctly compare StreamIDs or CommitIDs into.
There was a problem hiding this comment.
Okay. Not ideal, but worth giving it a shot and seeing how it fairs
stbrody
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ditto.