Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA: Update npm packages, some major version updates. Remove use of npm option legacy-peer-deps #2250

Merged
merged 7 commits into from
Sep 7, 2023

Conversation

chrieinv
Copy link
Contributor

@chrieinv chrieinv commented Apr 13, 2023

  • axios: Array in querystring is no longer sent as a JSON string
  • react-beautiful-dnd: Move DnD handling to each layout to fix layout issues during DnD caused by non-DnD items, fix card prop order not sequential after delete, fix cards with same order after converting to Millionaire game
  • react-dropzone: Requires a rendering function and no longer provides a preview

Remove unused packages react-emotion, react-event-listener, react-rte, react-tabs
Add missing peer-dependency i18next
npm can now be used without the legacy-peer-deps option

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #2250 (6bcf243) into master (c75c8d0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2250   +/-   ##
=========================================
  Coverage     60.27%   60.28%           
  Complexity     2774     2774           
=========================================
  Files           289      289           
  Lines         12550    12548    -2     
=========================================
  Hits           7565     7565           
+ Misses         4985     4983    -2     
Components Coverage Δ
contentauthor 60.28% <0.00%> (+<0.01%) ⬆️

@chrieinv chrieinv merged commit 1a8424e into master Sep 7, 2023
7 of 8 checks passed
@chrieinv chrieinv deleted the ca-npm-update-202304 branch September 7, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants