Update h5p packages #2291
Merged
Update h5p packages #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2291 +/- ##
============================================
+ Coverage 59.88% 61.60% +1.72%
- Complexity 2782 2800 +18
============================================
Files 289 289
Lines 12424 12473 +49
============================================
+ Hits 7440 7684 +244
+ Misses 4984 4789 -195
|
…ername, add/update unittests
This was
linked to
issues
May 15, 2023
emmachughes
requested changes
May 16, 2023
sourcecode/apis/contentauthor/tests/Unit/Libraries/H5P/FrameworkTest.php
Outdated
Show resolved
Hide resolved
sourcecode/apis/contentauthor/tests/Unit/Libraries/H5P/ViewConfigTest.php
Outdated
Show resolved
Hide resolved
sourcecode/apis/contentauthor/tests/Unit/H5PLibrariesHubCacheTest.php
Outdated
Show resolved
Hide resolved
…derName(). Some integration tests was in unit test folder
… update-h5p-packages-v2
emmachughes
reviewed
Sep 13, 2023
emmachughes
reviewed
Sep 13, 2023
sourcecode/apis/contentauthor/tests/Integration/Libraries/H5P/AjaxRequestTest.php
Outdated
Show resolved
Hide resolved
emmachughes
approved these changes
Sep 13, 2023
… in editor. Fix libraries fail to load resources from own folder
…r previously modified code, fix some tests marked as incomplete
emmachughes
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for patch version in library folder name