Add tests, fix PHPStan issues in tests, move misplaced integration test. Some minor bugfixes

[chrieinv]

No description provided.

[codecov]

Codecov Report

Merging #2569 (cb505d5) into master (31fc9fb) will increase coverage by 1.73%.
The diff coverage is 100.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2569      +/-   ##
============================================
+ Coverage     63.35%   65.08%   +1.73%     
+ Complexity     2732     2731       -1     
============================================
  Files           278      278              
  Lines         12131    12128       -3     
============================================
+ Hits           7685     7894     +209     
+ Misses         4446     4234     -212     

Components	Coverage Δ
contentauthor	65.08% <100.00%> (+1.73%)	⬆️

[emmachughes]

Regarding the added @var annotations (e.g. on Model::factory()->create()), are these necessary? They aren't for me, my IDE gets code completion without them, and from what I can tell, they don't do anything for PHPStan either.

[chrieinv]

I've had issues with the IDE not giving code completion in some cases.
Most of the fixes was the User model, and a closer inspection reveals that the User factory is missing the @template-extends in PHPDoc. Is there any reason why it shouldn't be added to the User factory?
The annotation is not required in most cases when using factory, but Model::factory()->count(3)->create() or Model::factory(3)->create() still seems to require it.

[emmachughes]

I think it's probably fine to add the annotation for UserFactory. It was initially left out because the User class doesn't represent an actual database table.