Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH #2580: Remove use of Auth0 for NDLA audio and image API #2582

Conversation

chrieinv
Copy link
Contributor

@chrieinv chrieinv commented Oct 24, 2023

Changes to the use of NDLA audio and image APIs to fix issues with H5P export sometimes failing if content from the API is used

  • Use the API without Auth0
  • Client side now access more of the API directly instead of through CA

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2582 (20a2a27) into master (ad4c05e) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2582      +/-   ##
============================================
+ Coverage     62.55%   62.78%   +0.23%     
- Complexity     2728     2737       +9     
============================================
  Files           279      279              
  Lines         12145    12146       +1     
============================================
+ Hits           7597     7626      +29     
+ Misses         4548     4520      -28     
Components Coverage Δ
contentauthor 62.78% <100.00%> (+0.23%) ⬆️

@chrieinv chrieinv marked this pull request as ready for review October 24, 2023 12:58
@chrieinv chrieinv merged commit 95ed61d into master Oct 31, 2023
8 checks passed
@chrieinv chrieinv deleted the 2580-download-of-h5p-export-fails-for-content-accessing-the-ndla-image-and-sound-api branch October 31, 2023 09:00
emmachughes pushed a commit that referenced this pull request Nov 2, 2023
* GH #2580: Remove use of Auth0 for NDLA audio and image API. Browsers now access more of the API directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download of H5P export fails for content accessing the NDLA image and sound-API
2 participants