Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ContentTypes stuff, fix bad redirect after adapter change #2771

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

emmachughes
Copy link
Member

Discovered while working on #2768

CA has a handful of classes that implement ContentTypesInterface. These are only used by /create/{contenttype?} / ContentController, which only gathers some data and then tries to render a non-existent view. This removes that route, controller, all the implementations of ContentTypesInterface, and the translations used exclusively by them.

Since the adapter switching controller redirects to that route (and results in an error), it is changed to return nothing, and the JS code is altered to just reload the page.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.80%. Comparing base (0b1b330) to head (1424257).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2771      +/-   ##
============================================
+ Coverage     69.67%   70.80%   +1.12%     
+ Complexity     2700     2671      -29     
============================================
  Files           272      263       -9     
  Lines         11536    11353     -183     
============================================
  Hits           8038     8038              
+ Misses         3498     3315     -183     
Components Coverage Δ
contentauthor 70.80% <ø> (+1.12%) ⬆️

@emmachughes emmachughes merged commit 8d76de7 into master Oct 2, 2024
8 checks passed
@emmachughes emmachughes deleted the ca-remove-content-type-interface branch October 2, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants