Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped libntech to master (3.24.x) #5632

Open
wants to merge 1 commit into
base: 3.24.x
Choose a base branch
from
Open

Bumped libntech to master (3.24.x) #5632

wants to merge 1 commit into from

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Nov 22, 2024

Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech

@larsewi
Bumped libntech to master
d463390 
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi marked this pull request as ready for review November 22, 2024 09:48
@larsewi
Copy link
Contributor Author

larsewi commented Nov 22, 2024

@cf-bottom Jenkins please :)

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11446/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11446/

craigcomstock
craigcomstock approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable :)

Is the bump for a particular purpose or reason? What initiated the bump?

@larsewi
Copy link
Contributor Author

larsewi commented Nov 22, 2024

Is the bump for a particular purpose or reason? What initiated the bump?

No particular reason @craigcomstock . Just though it's nice to keep these branches somewhat up to date with master. Can ofc wait til after release or not merge them at all.

@craigcomstock
Copy link
Contributor

Is the bump for a particular purpose or reason? What initiated the bump?

No particular reason @craigcomstock . Just though it's nice to keep these branches somewhat up to date with master. Can ofc wait til after release or not merge them at all.

I don't care too much one way or another, just figured it would be nice to include a "why" in the commit comment. Even just chore: or deps-update: sort of tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcomstock craigcomstock craigcomstock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larsewi @cf-bottom @craigcomstock