Merge pull request #110 from cgascoig/fix83

Don't try to resolve an moid as a name
cgascoig · Aug 7, 2023 · 586ee1d · 586ee1d
2 parents 1e23918 + a3784e6
commit 586ee1d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pkg/util/util.go b/pkg/util/util.go
@@ -96,6 +96,12 @@ func ParseMoRef(moref string) (string, string, bool) {
 	var r *regexp.Regexp
 	var m []string
 
+	r = regexp.MustCompile(`^[[:xdigit:]]{24}$`)
+	m = r.FindStringSubmatch(moref)
+	if m != nil {
+		return "", "", false
+	}
+
 	r = regexp.MustCompile(`MoRef\[\$filter:(.+)\]`)
 	m = r.FindStringSubmatch(moref)
 	if m != nil {

diff --git a/pkg/util/util_test.go b/pkg/util/util_test.go
@@ -73,6 +73,12 @@ func TestParseMoRef(t *testing.T) {
 			datatype: "",
 			ok:       true,
 		},
+		{
+			moref:    "59c84e4a16267c0001c23428",
+			filter:   "",
+			datatype: "",
+			ok:       false,
+		},
 	}
 
 	for _, test := range tests {