feat: upgrade dev toolchain (#285)

- Upgrades eslint (8.x, one major behind until we move to flat config)
- Upgrades chai (4.x, one major behind until we move to ESM)
- Upgrades mocha
- Moves from istanbul to c8 for coverage

.c8rc.json

@@ -0,0 +1,5 @@
+{
+ "reporter": ["lcov"],
+ "include": ["lib/**/*.js"],
+ "exclude": []
+}

.eslintrc.json

@@ -1,236 +1,16 @@
 {
  "root": true,
+ "extends": [
+ "eslint:recommended"
+ ],
  "env": {
  "node": true,
- "es6": true
+ "es2022": true
  },
  "parserOptions": {
- "ecmaVersion": 6
+ "ecmaVersion": "2022",
+ "sourceType": "module"
  },
  "rules": {
- // Possible errors
- "comma-dangle": ["error", "never"],
- "no-cond-assign": ["error", "except-parens"],
- "no-console": "error",
- "no-constant-condition": "error",
- "no-control-regex": "error",
- "no-debugger": "error",
- "no-dupe-args": "error",
- "no-dupe-keys": "error",
- "no-duplicate-case": "error",
- "no-empty": "error",
- "no-empty-character-class": "error",
- "no-ex-assign": "error",
- "no-extra-boolean-cast": "error",
- "no-extra-parens": ["error", "all", { "conditionalAssign": false, "nestedBinaryExpressions": false }],
- "no-extra-semi": "error",
- "no-func-assign": "error",
- "no-inner-declarations": "off",
- "no-invalid-regexp": "error",
- "no-irregular-whitespace": "error",
- "no-negated-in-lhs": "error",
- "no-obj-calls": "error",
- "no-regex-spaces": "error",
- "no-sparse-arrays": "error",
- "no-unexpected-multiline": "error",
- "no-unreachable": "error",
- "no-unsafe-finally": "off",
- "use-isnan": "error",
- "valid-jsdoc": "off",
- "valid-typeof": "error",
-
- // Best practices
- "accessor-pairs": "error",
- "array-callback-return": "error",
- "block-scoped-var": "off",
- "complexity": "off",
- "consistent-return": "error",
- "curly": ["error", "all"],
- "default-case": "off",
- "dot-location": ["error", "property"],
- "dot-notation": "error",
- "eqeqeq": "error",
- "guard-for-in": "off",
- "no-alert": "error",
- "no-caller": "error",
- "no-case-declarations": "error",
- "no-div-regex": "off",
- "no-else-return": "error",
- "no-empty-function": "error",
- "no-empty-pattern": "error",
- "no-eq-null": "error",
- "no-eval": "error",
- "no-extend-native": "error",
- "no-extra-bind": "error",
- "no-extra-label": "error",
- "no-fallthrough": "error",
- "no-floating-decimal": "error",
- "no-implicit-coercion": "error",
- "no-implicit-globals": "error",
- "no-implied-eval": "off",
- "no-invalid-this": "error",
- "no-iterator": "error",
- "no-labels": ["error", { "allowLoop": true }],
- "no-lone-blocks": "error",
- "no-loop-func": "off",
- "no-magic-numbers": "off",
- "no-multi-spaces": "error",
- "no-multi-str": "error",
- "no-native-reassign": "error",
- "no-new": "error",
- "no-new-func": "error",
- "no-new-wrappers": "error",
- "no-octal": "error",
- "no-octal-escape": "error",
- "no-param-reassign": "off",
- "no-process-env": "error",
- "no-proto": "error",
- "no-redeclare": "error",
- "no-return-assign": ["error", "except-parens"],
- "no-script-url": "off",
- "no-self-assign": "error",
- "no-self-compare": "error",
- "no-sequences": "error",
- "no-throw-literal": "error",
- "no-unmodified-loop-condition": "error",
- "no-unused-expressions": "error",
- "no-unused-labels": "error",
- "no-useless-call": "error",
- "no-useless-concat": "error",
- "no-useless-escape": "error",
- "no-void": "error",
- "no-warning-comments": "off",
- "no-with": "error",
- "radix": ["error", "as-needed"],
- "vars-on-top": "off",
- "wrap-iife": ["error", "outside"],
- "yoda": ["error", "never"],
-
- // Strict Mode
- "strict": ["error", "global"],
-
- // Variables
- "init-declarations": "off",
- "no-catch-shadow": "error",
- "no-delete-var": "error",
- "no-label-var": "error",
- "no-restricted-globals": "off",
- "no-shadow": "error",
- "no-shadow-restricted-names": "error",
- "no-undef": "error",
- "no-undef-init": "error",
- "no-undefined": "off",
- "no-unused-vars": "error",
- "no-use-before-define": ["error", "nofunc"],
-
- // Node.js and CommonJS
- "callback-return": "off",
- "global-require": "error",
- "handle-callback-err": "error",
- "no-mixed-requires": ["error", true],
- "no-new-require": "error",
- "no-path-concat": "error",
- "no-process-exit": "error",
- "no-restricted-imports": "off",
- "no-restricted-modules": "off",
- "no-sync": "off",
-
- // Stylistic Issues
- "array-bracket-spacing": ["error", "never"],
- "block-spacing": ["error", "always"],
- "brace-style": ["error", "1tbs", { "allowSingleLine": false }],
- "camelcase": ["error", { "properties": "always" }],
- "comma-spacing": ["error", { "before": false, "after": true }],
- "comma-style": ["error", "last"],
- "computed-property-spacing": ["error", "never"],
- "consistent-this": "off",
- "eol-last": "error",
- "func-names": "off",
- "func-style": ["error", "declaration"],
- "id-blacklist": "off",
- "id-length": "off",
- "id-match": "off",
- "indent": ["error", 4, { "SwitchCase": 1 }],
- "jsx-quotes": "off",
- "key-spacing": ["error", { "beforeColon": false, "afterColon": true, "mode": "strict" }],
- "keyword-spacing": ["error", { "before": true, "after": true }],
- "linebreak-style": ["error", "unix"],
- "lines-around-comment": "off",
- "max-depth": "off",
- "max-len": ["error", 120, { "ignoreUrls": true }],
- "max-nested-callbacks": "off",
- "max-params": "off",
- "max-statements": "off",
- "max-statements-per-line": ["error", { "max": 1 }],
- "new-cap": "error",
- "new-parens": "error",
- "newline-after-var": "off",
- "newline-before-return": "off",
- "newline-per-chained-call": "off",
- "no-array-constructor": "error",
- "no-bitwise": "off",
- "no-continue": "off",
- "no-inline-comments": "off",
- "no-lonely-if": "error",
- "no-mixed-spaces-and-tabs": "error",
- "no-multiple-empty-lines": "error",
- "no-negated-condition": "off",
- "no-nested-ternary": "error",
- "no-new-object": "error",
- "no-plusplus": "off",
- "no-restricted-syntax": "off",
- "no-spaced-func": "error",
- "no-ternary": "off",
- "no-trailing-spaces": "error",
- "no-underscore-dangle": "off",
- "no-unneeded-ternary": "error",
- "no-whitespace-before-property": "error",
- "object-curly-spacing": ["error", "always"],
- "one-var": ["error", "never"],
- "one-var-declaration-per-line": ["error", "initializations"],
- "operator-assignment": ["error", "always"],
- "operator-linebreak": ["error", "after"],
- "padded-blocks": ["error", "never"],
- "quote-props": ["error", "as-needed"],
- "quotes": ["error", "double", { "avoidEscape": true, "allowTemplateLiterals": true }],
- "require-jsdoc": "off",
- "semi": ["error", "always"],
- "semi-spacing": "error",
- "sort-imports": "off",
- "sort-vars": "off",
- "space-before-blocks": ["error", "always"],
- "space-before-function-paren": ["error", { "anonymous": "always", "named": "never" }],
- "space-in-parens": ["error", "never"],
- "space-infix-ops": "error",
- "space-unary-ops": ["error", { "words": true, "nonwords": false }],
- "spaced-comment": ["error", "always", { "markers": ["///"] }],
- "wrap-regex": "off",
-
- // ECMAScript 6
- "arrow-body-style": "off", // meh
- "arrow-parens": ["error", "as-needed"],
- "arrow-spacing": "error",
- "constructor-super": "error",
- "generator-star-spacing": ["error", "after"],
- "no-class-assign": "error",
- "no-confusing-arrow": "off",
- "no-const-assign": "error",
- "no-dupe-class-members": "error",
- "no-duplicate-imports": "error",
- "no-new-symbol": "error",
- "no-this-before-super": "error",
- "no-useless-computed-key": "error",
- "no-useless-constructor": "error",
- "no-var": "error",
- "object-shorthand": "error",
- "prefer-arrow-callback": "error",
- "prefer-const": "error",
- "prefer-reflect": "off",
- "prefer-rest-params": "off",
- "prefer-spread": "off",
- "prefer-template": "off",
- "require-yield": "error",
- "template-curly-spacing": ["error", "never"],
- "yield-star-spacing": ["error", "after"]
  }
 }

.github/workflows/ci.yml

@@ -32,7 +32,6 @@ jobs:
  # See supported Node.js release schedule at https://github.com/nodejs/release#release-schedule
  chai-version:
  - "^4.0.0"
- - "^5.0.0"
 
  steps:
  - uses: actions/checkout@v4

lib/chai-as-promised.js

@@ -263,7 +263,10 @@ module.exports = (chai, utils) => {
  getterNames.forEach(getterName => {
  // Chainable methods are things like `an`, which can work both for `.should.be.an.instanceOf` and as
  // `should.be.an("object")`. We need to handle those specially.
- const isChainableMethod = Assertion.prototype.__methods.hasOwnProperty(getterName);
+ const isChainableMethod = Object.prototype.hasOwnProperty.call(
+ Assertion.prototype.__methods,
+ getterName
+ );
 
  if (isChainableMethod) {
  Assertion.overwriteChainableMethod(